Fix base class of plLayerSDLAnimation
#281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the MOULa source code, the correct superclass is plLayerAnimationBase and not plLayerAnimation. libHSPlasma largely seems to agree - the CREATABLE declaration and all of the super method calls already use plLayerAnimationBase. The base class declarations saying plLayerAnimation were probably by accident.
dgelessus
added a commit
to dgelessus/PlasmaShop
that referenced
this pull request
Mar 2, 2024
The base class of plLayerSDLAnimation is actually plLayerAnimationBase and not plLayerAnimation. This was declared inconsistently in libHSPlasma (see H-uru/libhsplasma#281).
zrax
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the MOULa source code, the correct superclass is
plLayerAnimationBaseand notplLayerAnimation. libHSPlasma largely seems to agree - theCREATABLEdeclaration and all of the super method calls already useplLayerAnimationBase. The base class declarations sayingplLayerAnimationwere probably by accident.Someone who knows more than me about old Plasma should double-check this, but I think this change is correct for all Plasma versions - the read/write code has always used
plLayerAnimationBaseas the base class and that apparently worked fine for more than a decade.