Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed HDFFV-10480 (CVE-2018-11206) and HDFFV-11159 (CVE-2018-14033) #405

Merged
merged 22 commits into from
Mar 19, 2021
Merged

Fixed HDFFV-10480 (CVE-2018-11206) and HDFFV-11159 (CVE-2018-14033) #405

merged 22 commits into from
Mar 19, 2021

Commits on Mar 1, 2021

  1. Fixed HDFFV-10480 (CVE-2018-11206) and HDFFV-11159 (CVE-2018-14033) 

    Description
    Checked against buffer size to prevent segfault, in case of data corruption.

    + HDFFV-11159 CVE-2018-14033 Buffer over-read in H5O_layout_decode
    + HDFFV-10480 CVE-2018-11206 Buffer over-read in H5O_fill_new[/old]_decode
Platforms tested:
    Linux/64 (jelly)
    @bmribler
    bmribler committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    28da8dc View commit details
    Browse the repository at this point in the history

  2. Accidentally left in another occurrence of the previous patch from user 

       after a more correct fix was applied, that is the check now accounted
   for the previous advance of the buffer pointer.  Removed it.
    @bmribler
    bmribler committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    c1bdb0c View commit details
    Browse the repository at this point in the history

  3. Typo

    @bmribler
    bmribler committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    c24a0c2 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Fixed format issues.

    @bmribler
    bmribler committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    1dec6d8 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Added test.

    @bmribler
    bmribler committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    a147ae6 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Changed arguments to ADD_H5_TEST

    @bmribler
    bmribler committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    1671982 View commit details
    Browse the repository at this point in the history

  2. Fixing arguments to ADD_H5_TEST again.

    @bmribler
    bmribler committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    b45de82 View commit details
    Browse the repository at this point in the history

  3. Fixing arguments again.

    @bmribler
    bmribler committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    5832a70 View commit details
    Browse the repository at this point in the history

  4. Took out the CMake changes until Allen can help.

    @bmribler
    bmribler committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    c21324d View commit details
    Browse the repository at this point in the history

  5. Added files: 

    tCVE_2018_11206_fill_old.h5
tCVE_2018_11206_fill_new.h5
    @bmribler
    bmribler committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    8e71d59 View commit details
    Browse the repository at this point in the history

  6. Revert "Took out the CMake changes until Allen can help." 

    This reverts commit c21324d.
    @bmribler
    bmribler committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    d0a00d1 View commit details
    Browse the repository at this point in the history

  7. Revert "Fixing arguments again." 

    This reverts commit 5832a70.
    @bmribler
    bmribler committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    0c7c02e View commit details
    Browse the repository at this point in the history

  8. Revert "Fixing arguments to ADD_H5_TEST again." 

    This reverts commit b45de82.
    @bmribler
    bmribler committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    a030e91 View commit details
    Browse the repository at this point in the history

  9. Revert "Changed arguments to ADD_H5_TEST" 

    This reverts commit 1671982.
    @bmribler
    bmribler committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    9ae8bd2 View commit details
    Browse the repository at this point in the history

  10. Added first argument to ADD_H5_TEST for HDFFV-10480 fix.

    @bmribler
    bmribler committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    b8a0f9a View commit details
    Browse the repository at this point in the history

  11. Changed argument 0 to 1

    @bmribler
    bmribler committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    b343d66 View commit details
    Browse the repository at this point in the history

  12. Revert "Changed argument 0 to 1" 

    This reverts commit b343d66.
    @bmribler
    bmribler committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    5060450 View commit details
    Browse the repository at this point in the history

  13. Revert "Added first argument to ADD_H5_TEST for HDFFV-10480 fix." 

    This reverts commit b8a0f9a.
    @bmribler
    bmribler committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    fcfbacb View commit details
    Browse the repository at this point in the history

  14. Added first argument and corrected the second.

    @bmribler
    bmribler committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    5213c5a View commit details
    Browse the repository at this point in the history

  15. Updated fixes for HDFFV-10480 and HDFFV-11159/HDFFV-11049

    @bmribler
    bmribler committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    e5e2404 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Improved error messages.

    @bmribler
    bmribler committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    0c04d8b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into bmr_dev_HDFFV-10480_HDFFV-11159

    @bmribler
    bmribler authored Mar 17, 2021
    Configuration menu
    Copy the full SHA
    64490c6 View commit details
    Browse the repository at this point in the history