-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed HDFFV-10480 (CVE-2018-11206) and HDFFV-11159 (CVE-2018-14033) #405
Merged
lrknox
merged 22 commits into
HDFGroup:develop
from
bmribler:bmr_dev_HDFFV-10480_HDFFV-11159
Mar 19, 2021
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
28da8dc
Fixed HDFFV-10480 (CVE-2018-11206) and HDFFV-11159 (CVE-2018-14033)
bmribler c1bdb0c
Accidentally left in another occurrence of the previous patch from…
bmribler c24a0c2
Typo
bmribler 1dec6d8
Fixed format issues.
bmribler a147ae6
Added test.
bmribler 1671982
Changed arguments to ADD_H5_TEST
bmribler b45de82
Fixing arguments to ADD_H5_TEST again.
bmribler 5832a70
Fixing arguments again.
bmribler c21324d
Took out the CMake changes until Allen can help.
bmribler 8e71d59
Added files:
bmribler d0a00d1
Revert "Took out the CMake changes until Allen can help."
bmribler 0c7c02e
Revert "Fixing arguments again."
bmribler a030e91
Revert "Fixing arguments to ADD_H5_TEST again."
bmribler 9ae8bd2
Revert "Changed arguments to ADD_H5_TEST"
bmribler b8a0f9a
Added first argument to ADD_H5_TEST for HDFFV-10480 fix.
bmribler b343d66
Changed argument 0 to 1
bmribler 5060450
Revert "Changed argument 0 to 1"
bmribler fcfbacb
Revert "Added first argument to ADD_H5_TEST for HDFFV-10480 fix."
bmribler 5213c5a
Added first argument and corrected the second.
bmribler e5e2404
Updated fixes for HDFFV-10480 and HDFFV-11159/HDFFV-11049
bmribler 0c04d8b
Improved error messages.
bmribler 64490c6
Merge branch 'develop' into bmr_dev_HDFFV-10480_HDFFV-11159
bmribler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if ADD_H5_TEST should be ADD_H5_GREP_TEST and search that the test failure that is expected and doesn't fail for some other reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but TOOLTEST_FAIL took care of that, it would detect the segfault. I wish the author would put some comments to these macros... :-/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh it segfaults - okay then this is fine.