Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nvc warnings for unreachable break #4298

Closed
wants to merge 1 commit into from
Closed

Fix nvc warnings for unreachable break #4298

wants to merge 1 commit into from

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented Apr 1, 2024 

"/pscratch/sd/l/lrknox/dt-perlm/CI/hdf5-1.15.0/src/H5trace.c", line 2414: warning: statement is unreachable [code_is_unreachable]                           break;                           ^  [CTest: warning matched] Remark: individual 

"/pscratch/sd/l/lrknox/dt-perlm/CI/hdf5-1.15.0/src/H5trace.c", line 2430: warning: statement is unreachable [code_is_unreachable]                           break;                           ^

@hyoklee hyoklee added the Component - C Library Core C library issues (usually in the src directory) label Apr 1, 2024
jhendersonHDF
jhendersonHDF reviewed Apr 1, 2024
View reviewed changes
src/H5trace.c
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make use of any warning suppression options that NVHPC has rather than just removing the break statements. Otherwise, if this code's refactored in the future someone may forget to add a break back.

@hyoklee hyoklee closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendersonHDF jhendersonHDF jhendersonHDF left review comments

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - C Library Core C library issues (usually in the src directory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyoklee @jhendersonHDF