Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nvc warnings for unreachable break #4298

Closed
wants to merge 1 commit into from
Closed

Fix nvc warnings for unreachable break #4298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/H5trace.c
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make use of any warning suppression options that NVHPC has rather than just removing the break statements. Otherwise, if this code's refactored in the future someone may forget to add a break back.

Original file line number Diff line number Diff line change
Expand Up @@ -2411,7 +2411,6 @@ H5_trace_args(H5RS_str_t *rs, const char *type, va_list ap)
H5RS_acat(rs, "Reference Region");
goto error;
} /* end block */
break;

case 'o': /* hobj_ref_t */
{
Expand All @@ -2427,7 +2426,6 @@ H5_trace_args(H5RS_str_t *rs, const char *type, va_list ap)
H5RS_acat(rs, "Reference Opaque");
goto error;
} /* end block */
break;

case 't': /* H5R_type_t */
{
Expand Down
Loading