Reduce test iterations, etc. to keep time down on slower systems #4853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Quincey Koziol <quincey@koziol.cc>
qkoziol
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
lrknox
reviewed
Sep 18, 2024
| #define NUM_ITERS 32 | ||
| #define COUNT_MAX 1024 | ||
| #define NUM_ITERS 12 | ||
| #define COUNT_MAX 512 |
There was a problem hiding this comment.
16 and 512 reduced runtime on echidna to 23 minutes; 8 and 512 reduced it to 8 minutes. 12 seems like a happy medium, I'll test it. This isn't a problem on most other tested machines. If it works on echidna I expect it has a good chance to eliminate any occasional failures elsewhere.
There was a problem hiding this comment.
Some, but maybe not all of the echidna test configurations will pass. It may need one last revision of the numbers, but I think it's worthwhile to try these to see where it stands,
There was a problem hiding this comment.
Feel free to reduce the # of iterations down to 10 (or 8, even) if necessary.
lrknox
approved these changes
Sep 19, 2024
derobins
approved these changes
Sep 19, 2024
derobins
added
Merge - Develop Only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.