Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce test iterations, etc. to keep time down on slower systems #4853

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Reduce test iterations, etc. to keep time down on slower systems #4853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/ttsafe_rwlock.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
#define NUM_THREADS 16
#define NUM_WRITERS 4

#define NUM_ITERS 32
#define COUNT_MAX 1024
#define NUM_ITERS 12
#define COUNT_MAX 512
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16 and 512 reduced runtime on echidna to 23 minutes; 8 and 512 reduced it to 8 minutes. 12 seems like a happy medium, I'll test it. This isn't a problem on most other tested machines. If it works on echidna I expect it has a good chance to eliminate any occasional failures elsewhere.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some, but maybe not all of the echidna test configurations will pass. It may need one last revision of the numbers, but I think it's worthwhile to try these to see where it stands,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to reduce the # of iterations down to 10 (or 8, even) if necessary.


typedef struct {
H5TS_rwlock_t lock;
Expand Down
Loading