Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve grammar and style of comment block in bin/genparser #4879

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Improve grammar and style of comment block in bin/genparser #4879

merged 2 commits into from
Sep 27, 2024

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented Sep 26, 2024

  • Capitalize.
  • Fix typo - H5LTlparse.h.
  • Remove the use of I in sentences.

@hyoklee hyoklee added Component - Build CMake, Autotools Merge - To 1.14 This needs to be merged to HDF5 1.14 Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Improvement Improvements that don't add a new feature or functionality perl Related to perl scripts labels Sep 26, 2024
lrknox
lrknox reviewed Sep 26, 2024
View reviewed changes
bin/genparser Outdated Show resolved Hide resolved
@lrknox lrknox merged commit 1fe032d into HDFGroup:develop Sep 27, 2024
56 checks passed
@hyoklee hyoklee deleted the hyoklee-hdf5-258 branch September 27, 2024 16:03
lrknox pushed a commit to lrknox/hdf5 that referenced this pull request Oct 2, 2024
@hyoklee @lrknox
Improve grammar and style of comment block in bin/genparser (HDFGroup…
9715b47 
…#4879)
lrknox pushed a commit that referenced this pull request Oct 2, 2024
@hyoklee @lrknox
Improve grammar and style of comment block in bin/genparser (#4879)
1de4a6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrknox lrknox lrknox approved these changes

@byrnHDF byrnHDF byrnHDF approved these changes

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - Build CMake, Autotools Merge - To 1.14 This needs to be merged to HDF5 1.14 perl Related to perl scripts Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Improvement Improvements that don't add a new feature or functionality
Projects
Downstream HDF5 Merges
Status: Needs Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyoklee @lrknox @byrnHDF