Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve grammar and style of comment block in bin/genparser #4879

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Improve grammar and style of comment block in bin/genparser #4879

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b5e662
Improve grammar and style of comment block in bin/genparser
hyoklee Sep 26, 2024
7d27c1f
address @lrknox review
hyoklee Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions bin/genparser
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,14 +200,14 @@ if [ "$verbose" = true ] ; then
fi
${HDF5_FLEX} --nounistd -PH5LTyy -o ${path_to_hl_src}/H5LTanalyze.c ${path_to_hl_src}/H5LTanalyze.l

# fix H5LTparse.c and H5LTlparse.h to declare H5LTyyparse return type as an
# hid_t instead of int. Currently the generated function H5LTyyparse is
# generated with a return value of type int, which is a mapping to the
# Fix H5LTparse.c and H5LTparse.h to declare H5LTyyparse return type as an
# hid_t instead of int. Currently, the H5LTyyparse function is generated
# with a return value of type int, which is a mapping to the
# flex yyparse function. The return value in the HL library should be
# an hid_t.
# I propose to not use flex to generate this function, but for now I am
# adding a perl command to find and replace this function declaration in
# H5LTparse.c.
# A Perl command will be added to find and replace this function declaration
hyoklee marked this conversation as resolved.
Show resolved Hide resolved
# in H5LTparse.c. This is a temporary solution until a method that does not
# use flex is implemented.
perl -0777 -pi -e 's/int yyparse/hid_t yyparse/igs' ${path_to_hl_src}/H5LTparse.c
perl -0777 -pi -e 's/int\nyyparse/hid_t\nyyparse/igs' ${path_to_hl_src}/H5LTparse.c
perl -0777 -pi -e 's/int H5LTyyparse/hid_t H5LTyyparse/igs' ${path_to_hl_src}/H5LTparse.c
Expand Down
Loading