[BUG] Test failures on big-endian #2697

matoro · 2023-03-22T21:18:45Z

Hi - I am running into test failures on big-endian architectures. I have two identical PPC VM's, one LE one BE, with identical kernels and userspaces.

In the LE machine:

100% tests passed, 0 tests failed out of 217

Total Test time (real) = 126.86 sec

The following tests did not run:
        208 - CTimer.SleeptoAccuracy (Disabled)

In the BE machine:

96% tests passed, 9 tests failed out of 217

Total Test time (real) =  88.52 sec

The following tests did not run:
        208 - CTimer.SleeptoAccuracy (Disabled)

The following tests FAILED:
         24 - CIPAddress.IPv6_pton (Failed)
         89 - TestFEC.Connection (Failed)
         90 - TestFEC.ConnectionReorder (Failed)
         91 - TestFEC.ConnectionFull1 (Failed)
         92 - TestFEC.ConnectionFull2 (Failed)
         93 - TestFEC.ConnectionMess (Failed)
         94 - TestFEC.ConnectionForced (Failed)
        105 - TestIPv6.v6_calls_v4 (Failed)
        200 - SyncEvent.WaitForTwoNotifyOne (Failed)

Version tested: srt-1.5.1
Specific failures from LastTest.log:

24/218 Testing: CIPAddress.IPv6_pton
24/218 Test: CIPAddress.IPv6_pton
Command: "/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64/test-srt" "--gtest_filter=CIPAddress.IPv6_pton"
Directory: /var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64
"CIPAddress.IPv6_pton" start time: Mar 22 21:03 UTC
Output:
----------------------------------------------------------
Running main() from /var/tmp/portage/dev-cpp/gtest-1.11.0/work/googletest-release-1.11.0/googletest/src/gtest_main.cc
Note: Google Test filter = CIPAddress.IPv6_pton
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from CIPAddress
[ RUN      ] CIPAddress.IPv6_pton
/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1/test/test_common.cpp:40: Failure
Expected equality of these values:
  peer
    Which is: 32-byte object <00-0A 10-68 00-00 00-00 20-01 0D-B8 85-A3 08-D3 13-19 8A-2E 03-70 73-48 00-00 00-00 00-00 00-1C>
  host
    Which is: 32-byte object <00-0A 10-68 00-00 00-00 B8-0D 01-20 D3-08 A3-85 2E-8A 19-13 48-73 70-03 00-00 00-00 00-00 00-1C>
Peer 2001:db8:85a3:8d3:1319:8a2e:370:7348:4200 host b80d:120:d308:a385:2e8a:1913:4873:7003:4200
[  FAILED  ] CIPAddress.IPv6_pton (0 ms)
[----------] 1 test from CIPAddress (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (0 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CIPAddress.IPv6_pton

 1 FAILED TEST
<end of output>
Test time =   0.03 sec
----------------------------------------------------------
Test Failed.
"CIPAddress.IPv6_pton" end time: Mar 22 21:03 UTC
"CIPAddress.IPv6_pton" time elapsed: 00:00:00
----------------------------------------------------------


89/218 Testing: TestFEC.Connection
89/218 Test: TestFEC.Connection
Command: "/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64/test-srt" "--gtest_filter=TestFEC.Connection"
Directory: /var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64
"TestFEC.Connection" start time: Mar 22 21:04 UTC
Output:
----------------------------------------------------------
Running main() from /var/tmp/portage/dev-cpp/gtest-1.11.0/work/googletest-release-1.11.0/googletest/src/gtest_main.cc
Note: Google Test filter = TestFEC.Connection
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestFEC
[ RUN      ] TestFEC.Connection
21:04:22.323764/SRT:RcvQ:w1*E:SRT.cn: PEER'S FILTER CONFIG [,cefsloc,01:swor] has been rejected
21:04:22.333896/SRT:RcvQ:w1!W:SRT.cn: @342992677:newConnection: connection rejected due to: INTERNAL REJECTION - ERROR:FILTER
21:04:22.333925/SRT:RcvQ:w1!W:SRT.cn: processConnectRequest: rsp(REJECT): 1014 - Packet Filter settings error
/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1/test/test_fec_rebuilding.cpp:311: Failure
Expected: (a) != (SRT_ERROR), actual: -1 vs -1
[  FAILED  ] TestFEC.Connection (2009 ms)
[----------] 1 test from TestFEC (2009 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (2009 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] TestFEC.Connection

 1 FAILED TEST
<end of output>
Test time =   2.22 sec
----------------------------------------------------------
Test Failed.
"TestFEC.Connection" end time: Mar 22 21:04 UTC
"TestFEC.Connection" time elapsed: 00:00:02
----------------------------------------------------------


90/218 Testing: TestFEC.ConnectionReorder
90/218 Test: TestFEC.ConnectionReorder
Command: "/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64/test-srt" "--gtest_filter=TestFEC.ConnectionReorder"
Directory: /var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64
"TestFEC.ConnectionReorder" start time: Mar 22 21:04 UTC
Output:
----------------------------------------------------------
Running main() from /var/tmp/portage/dev-cpp/gtest-1.11.0/work/googletest-release-1.11.0/googletest/src/gtest_main.cc
Note: Google Test filter = TestFEC.ConnectionReorder
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestFEC
[ RUN      ] TestFEC.ConnectionReorder
21:04:24.681602/SRT:RcvQ:w1*E:SRT.cn: PEER'S FILTER CONFIG [,cefsloc,01:swor] has been rejected
21:04:24.692087/SRT:RcvQ:w1!W:SRT.cn: @680337288:newConnection: connection rejected due to: INTERNAL REJECTION - ERROR:FILTER
21:04:24.692113/SRT:RcvQ:w1!W:SRT.cn: processConnectRequest: rsp(REJECT): 1014 - Packet Filter settings error
/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1/test/test_fec_rebuilding.cpp:364: Failure
Expected: (a) != (SRT_ERROR), actual: -1 vs -1
[  FAILED  ] TestFEC.ConnectionReorder (2007 ms)
[----------] 1 test from TestFEC (2007 ms total)
 
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (2007 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] TestFEC.ConnectionReorder
 
 1 FAILED TEST
<end of output>
Test time =   2.29 sec
----------------------------------------------------------
Test Failed.
"TestFEC.ConnectionReorder" end time: Mar 22 21:04 UTC
"TestFEC.ConnectionReorder" time elapsed: 00:00:02
----------------------------------------------------------


91/218 Testing: TestFEC.ConnectionFull1
91/218 Test: TestFEC.ConnectionFull1
Command: "/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64/test-srt" "--gtest_filter=TestFEC.ConnectionFull1"
Directory: /var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64
"TestFEC.ConnectionFull1" start time: Mar 22 21:04 UTC
Output:
----------------------------------------------------------
Running main() from /var/tmp/portage/dev-cpp/gtest-1.11.0/work/googletest-release-1.11.0/googletest/src/gtest_main.cc
Note: Google Test filter = TestFEC.ConnectionFull1
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestFEC
[ RUN      ] TestFEC.ConnectionFull1
21:04:27.041575/SRT:RcvQ:w1*E:SRT.cn: PEER'S FILTER CONFIG [,cefsloc,01:swor,02::qraevenal,rtuoyeve:] has been rejected
21:04:27.046499/SRT:RcvQ:w1!W:SRT.cn: @48051114:newConnection: connection rejected due to: INTERNAL REJECTION - ERROR:FILTER
21:04:27.046527/SRT:RcvQ:w1!W:SRT.cn: processConnectRequest: rsp(REJECT): 1014 - Packet Filter settings error
/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1/test/test_fec_rebuilding.cpp:417: Failure
Expected: (a) != (SRT_ERROR), actual: -1 vs -1
[  FAILED  ] TestFEC.ConnectionFull1 (2009 ms)
[----------] 1 test from TestFEC (2009 ms total)
 
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (2009 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] TestFEC.ConnectionFull1
 
 1 FAILED TEST
<end of output>
Test time =   2.34 sec
----------------------------------------------------------
Test Failed.
"TestFEC.ConnectionFull1" end time: Mar 22 21:04 UTC
"TestFEC.ConnectionFull1" time elapsed: 00:00:02
----------------------------------------------------------


92/218 Testing: TestFEC.ConnectionFull2
92/218 Test: TestFEC.ConnectionFull2
Command: "/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64/test-srt" "--gtest_filter=TestFEC.ConnectionFull2"
Directory: /var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64
"TestFEC.ConnectionFull2" start time: Mar 22 21:04 UTC
Output:
----------------------------------------------------------
Running main() from /var/tmp/portage/dev-cpp/gtest-1.11.0/work/googletest-release-1.11.0/googletest/src/gtest_main.cc
Note: Google Test filter = TestFEC.ConnectionFull2
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestFEC
[ RUN      ] TestFEC.ConnectionFull2
21:04:29.276540/SRT:RcvQ:w1*E:SRT.cn: PEER'S FILTER CONFIG [,cefsloc,01:swor,02::qraawlal,syuoyave:t] has been rejected
21:04:29.281613/SRT:RcvQ:w1!W:SRT.cn: @341528805:newConnection: connection rejected due to: INTERNAL REJECTION - ERROR:FILTER
21:04:29.281643/SRT:RcvQ:w1!W:SRT.cn: processConnectRequest: rsp(REJECT): 1014 - Packet Filter settings error
/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1/test/test_fec_rebuilding.cpp:469: Failure
Expected: (a) != (SRT_ERROR), actual: -1 vs -1
[  FAILED  ] TestFEC.ConnectionFull2 (2007 ms)
[----------] 1 test from TestFEC (2007 ms total)
 
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (2007 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] TestFEC.ConnectionFull2
 
 1 FAILED TEST
<end of output>
Test time =   2.20 sec
----------------------------------------------------------
Test Failed.
"TestFEC.ConnectionFull2" end time: Mar 22 21:04 UTC
"TestFEC.ConnectionFull2" time elapsed: 00:00:02
----------------------------------------------------------


93/218 Testing: TestFEC.ConnectionMess
93/218 Test: TestFEC.ConnectionMess
Command: "/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64/test-srt" "--gtest_filter=TestFEC.ConnectionMess"
Directory: /var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64
"TestFEC.ConnectionMess" start time: Mar 22 21:04 UTC
Output:
----------------------------------------------------------
Running main() from /var/tmp/portage/dev-cpp/gtest-1.11.0/work/googletest-release-1.11.0/googletest/src/gtest_main.cc
Note: Google Test filter = TestFEC.ConnectionMess
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestFEC
[ RUN      ] TestFEC.ConnectionMess
21:04:31.512007/SRT:RcvQ:w1*E:SRT.cn: PEER'S FILTER CONFIG [,cefslococ,:1:sl] has been rejected
21:04:31.512840/SRT:RcvQ:w1!W:SRT.cn: @885581131:newConnection: connection rejected due to: INTERNAL REJECTION - ERROR:FILTER
21:04:31.512867/SRT:RcvQ:w1!W:SRT.cn: processConnectRequest: rsp(REJECT): 1014 - Packet Filter settings error
/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1/test/test_fec_rebuilding.cpp:522: Failure
Expected: (a) != (SRT_ERROR), actual: -1 vs -1
[  FAILED  ] TestFEC.ConnectionMess (2007 ms)
[----------] 1 test from TestFEC (2007 ms total)
 
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (2007 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] TestFEC.ConnectionMess
 
 1 FAILED TEST
<end of output>
Test time =   2.18 sec
----------------------------------------------------------
Test Failed.
"TestFEC.ConnectionMess" end time: Mar 22 21:04 UTC
"TestFEC.ConnectionMess" time elapsed: 00:00:02
----------------------------------------------------------


94/218 Testing: TestFEC.ConnectionForced
94/218 Test: TestFEC.ConnectionForced
Command: "/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64/test-srt" "--gtest_filter=TestFEC.ConnectionForced"
Directory: /var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64
"TestFEC.ConnectionForced" start time: Mar 22 21:04 UTC
Output:
----------------------------------------------------------
Running main() from /var/tmp/portage/dev-cpp/gtest-1.11.0/work/googletest-release-1.11.0/googletest/src/gtest_main.cc
Note: Google Test filter = TestFEC.ConnectionForced
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestFEC
[ RUN      ] TestFEC.ConnectionForced
21:04:33.612095/SRT:RcvQ:w1*E:SRT.cn: PEER'S FILTER CONFIG [,cefswor,02:sloc] has been rejected
21:04:33.617116/SRT:RcvQ:w1!W:SRT.cn: @735156762:newConnection: connection rejected due to: INTERNAL REJECTION - ERROR:FILTER
21:04:33.617145/SRT:RcvQ:w1!W:SRT.cn: processConnectRequest: rsp(REJECT): 1014 - Packet Filter settings error
/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1/test/test_fec_rebuilding.cpp:573: Failure
Expected: (a) != (SRT_ERROR), actual: -1 vs -1
[  FAILED  ] TestFEC.ConnectionForced (2001 ms)
[----------] 1 test from TestFEC (2001 ms total)
 
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (2001 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] TestFEC.ConnectionForced
 
 1 FAILED TEST
<end of output>
Test time =   2.07 sec
----------------------------------------------------------
Test Failed.
"TestFEC.ConnectionForced" end time: Mar 22 21:04 UTC
"TestFEC.ConnectionForced" time elapsed: 00:00:02
----------------------------------------------------------


105/218 Testing: TestIPv6.v6_calls_v4
105/218 Test: TestIPv6.v6_calls_v4
Command: "/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64/test-srt" "--gtest_filter=TestIPv6.v6_calls_v4"
Directory: /var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64
"TestIPv6.v6_calls_v4" start time: Mar 22 21:04 UTC
Output:
----------------------------------------------------------
Running main() from /var/tmp/portage/dev-cpp/gtest-1.11.0/work/googletest-release-1.11.0/googletest/src/gtest_main.cc
Note: Google Test filter = TestIPv6.v6_calls_v4
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestIPv6
[ RUN      ] TestIPv6.v6_calls_v4
Calling: 0::FFFF:127.0.0.1(IPv6)
21:04:50.957713/SRT:RcvQ:w1*E:SRT.in: pton: IPE or net error: can't determine IPv4 carryover format: 0:0:0:0:ffff:0:100:7f
21:04:50.958523/SRT:RcvQ:w1*E:SRT.in: pton: IPE or net error: can't determine IPv4 carryover format: 0:0:0:0:ffff:0:100:7f
ACCEPTED Sock name: : 0.0.0.0:4200 (IPv4)
ACCEPTED Peer name: : 127.0.0.1:57028 (IPv4)
CALLER Sock name: : ::ffff:127.0.0.1:57028 (IPv6)
/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1/test/test_ipv6.cpp:94: Failure
Expected: (memcmp(ipv6_zero, sn.get_addr(), sizeof ipv6_zero)) != (0), actual: 0 vs 0
EMPTY address in srt_getsockname
CALLER Peer name: : ::ffff:127.0.0.1:57028 (IPv6)
/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1/test/test_ipv6.cpp:192: Failure
Expected equality of these values:
  sa_accepted.str()
    Which is: "0.0.0.0:4200"
  "127.0.0.1:4200"
[  FAILED  ] TestIPv6.v6_calls_v4 (39 ms)
[----------] 1 test from TestIPv6 (39 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (39 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] TestIPv6.v6_calls_v4

 1 FAILED TEST
<end of output>
Test time =   0.08 sec
----------------------------------------------------------
Test Failed.
"TestIPv6.v6_calls_v4" end time: Mar 22 21:04 UTC
"TestIPv6.v6_calls_v4" time elapsed: 00:00:00
----------------------------------------------------------


200/218 Testing: SyncEvent.WaitForTwoNotifyOne
200/218 Test: SyncEvent.WaitForTwoNotifyOne
Command: "/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64/test-srt" "--gtest_filter=SyncEvent.WaitForTwoNotifyOne"
Directory: /var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1_build-.ppc64
"SyncEvent.WaitForTwoNotifyOne" start time: Mar 22 21:05 UTC
Output:
----------------------------------------------------------
Running main() from /var/tmp/portage/dev-cpp/gtest-1.11.0/work/googletest-release-1.11.0/googletest/src/gtest_main.cc
Note: Google Test filter = SyncEvent.WaitForTwoNotifyOne
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from SyncEvent
[ RUN      ] SyncEvent.WaitForTwoNotifyOne
SyncEvent::WaitForTwoNotifyOne: NOTIFICATION came from 0 clients:
/var/tmp/portage/net-libs/srt-1.5.1/work/srt-1.5.1/test/test_sync.cpp:478: Failure
Expected equality of these values:
  notified_clients.size()
    Which is: 0
  1U
    Which is: 1
[  FAILED  ] SyncEvent.WaitForTwoNotifyOne (3001 ms)
[----------] 1 test from SyncEvent (3001 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (3001 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SyncEvent.WaitForTwoNotifyOne

 1 FAILED TEST
<end of output>
Test time =   3.03 sec
----------------------------------------------------------
Test Failed.
"SyncEvent.WaitForTwoNotifyOne" end time: Mar 22 21:05 UTC
"SyncEvent.WaitForTwoNotifyOne" time elapsed: 00:00:03
----------------------------------------------------------

The last of these failures, SyncEvent.WaitForTwoNotifyOne is intermittent and does not appear on every run, however it has never appeared on LE.

Thank you for taking a look, and please let me know if there is any other information I can provide!

The text was updated successfully, but these errors were encountered:

These currently DO NOT PASS on big-endian, see Haivision/srt#2697 Bug: https://bugs.gentoo.org/900240 Signed-off-by: Matoro Mahri <matoro@users.noreply.github.com>

ethouris · 2023-04-03T13:15:25Z

Thanks for the fix; although if you say that #2708 is partial, which things reported in this bug are not fixed?

yomnes0 · 2023-04-03T13:19:36Z

Out of the 9 failed tests, 6 are related to packet filter not being properly interpreted. Those are fixed. The remaining unfixed 3 are :
CIPAddress.IPv6_pton
TestIPv6.v6_calls_v4
SyncEvent.WaitForTwoNotifyOne

The first 2 are both related to an error in pton method, I'm not quite sure what"s happenning yet (but I can see byte ordering issues).

maxsharabayko · 2023-04-03T16:10:02Z

SyncEvent.WaitForTwoNotifyOne sometimes triggers a false-positive failure. Please ignore it for now.

These currently DO NOT PASS on big-endian, see Haivision/srt#2697 Bug: https://bugs.gentoo.org/900240 Signed-off-by: Matoro Mahri <matoro@users.noreply.github.com>

These currently DO NOT PASS on big-endian, see Haivision/srt#2697 Bug: https://bugs.gentoo.org/900240 Signed-off-by: Matoro Mahri <matoro@users.noreply.github.com> Closes: #30307 Signed-off-by: Sam James <sam@gentoo.org>

Fixes the last two remaining test failures on big-endian. These operations were all already no-ops on little-endian, and unnecessarily byteswapped the IP addresses on big-endian. Closes: Haivision#2697

Fixes the last two remaining test failures on big-endian. These operations were all already no-ops on little-endian, and unnecessarily byteswapped the IP addresses on big-endian. Closes: #2697

* [core] Fix crypto mode auto for listener sender (Haivision#2711). Co-authored-by: oviano <ovcollyer@mac.com> * [build] Upgraded CI: ubuntu to version 20.04 (Haivision#2682). * [docs] Added the link for registration in slack to the getting started table (Haivision#2721). * [core] Fixed FEC Emergency resize crash (Haivision#2717). Fixed minimum history condition. * [core] Fixed various compiler warnings on various platforms (Haivision#2679). * [core] Minor fix of variable shadowing. * [tests] Minor fix of variable shadowing. * [build] Add -Wshadow=local to CMake build flags. Supported since GCC 7.0. * [core] Correct remaining endianness issues Fixes the last two remaining test failures on big-endian. These operations were all already no-ops on little-endian, and unnecessarily byteswapped the IP addresses on big-endian. Closes: Haivision#2697 * [docs] Minor updates to AEAD docs plus changed v1.6.0 to 1.5.2 in some files * [build] Fix downversioning of _WIN32_WINNT (Haivision#2754). * [core] Fixed unhandled error in haicrypt (Haivision#2685). * [core] Use overlapped WSASendTo to avoid loss in UDP sending (Haivision#2632). * [core] Add volatile keyword to asm block in rdtsc (Haivision#2759). * [core] Fixed srctime from closing socket was mistakenly cleared * [core] Fixed group read-ready epoll events. * [core] Removed unused CUDTGroup::m_Positions. * [core] Perf improvement of group reading. * [core] Fixed RCV buffer initialization in Rendezvous. * [docs] Updating the explicit information for binding to IPv6 wildcard (Haivision#2765). * [tests] Added custom main with transparent parameters for tests (Haivision#2681). * [core] Fix memory leak when can't buffer a HS packet (Haivision#2757). * [core] Refactor CRcvQueue::storePkt(..) for better resource management (Haivision#2775). * [core] Fix hang up on not enough space in the RCV buffer (Haivision#2745). When there is space available in the receiving buffer after it is full, send an ack to allow the sender to resume transmission. Reschedule sending if ACK decreases the flight span after sending is congested. Co-authored-by: Maxim Sharabayko <maxlovic@gmail.com> * [core] fix tsbpd() may deadlock with processCtrlShutdown() * [core] Slightly optimize the RCV drop by message number (Haivision#2686). Some minor improvements of logs and comments. * [core] Rejection not undertaken in rendezvous after KMX failure (Haivision#2692). * [core] Fix: In rendezvous when processing resulted in ACCEPT it was still sending rejection * [core] Minor code clean up in CRateEstimator. * [core] Initialize ISN and PeerISN in CUDT. * [core] Drop unencrypted packets in GCM mode. * [apps] Fix the build for target without IP_ADD_SOURCE_MEMBERSHIP (Haivision#2779). * [core] Added maximum BW limit for retransmissions (Haivision#2714). * [API] SRT version raised to 1.5.3. * [apps] Fixed conditional IP_ADD_SOURCE_MEMBERSHIP in testmedia (Haivision#2780). * [core] Fixed SRT_ATTR_REQUIRES use. * [build] Added missing public header files in Windows binary installer (Haivision#2784). The header file access_control.h was added to the source tree at some point but was not added to the Windows installer. --------- Co-authored-by: Maxim Sharabayko <maxlovic@gmail.com> Co-authored-by: oviano <ovcollyer@mac.com> Co-authored-by: Sektor van Skijlen <ethouris@gmail.com> Co-authored-by: Maria Sharabayko <41019697+mbakholdina@users.noreply.github.com> Co-authored-by: Maxim Sharabayko <maxsharabayko@haivision.com> Co-authored-by: matoro <matoro@users.noreply.github.com> Co-authored-by: Maria Sharabayko <msharabayko@haivision.com> Co-authored-by: Steve Lhomme <robux4@ycbcr.xyz> Co-authored-by: Aaron Jencks <32805004+aaron-jencks@users.noreply.github.com> Co-authored-by: Guangqing Chen <hi@goushi.me> Co-authored-by: john <hondaxiao@tencent.com> Co-authored-by: yomnes0 <127947185+yomnes0@users.noreply.github.com> Co-authored-by: Mikołaj Małecki <mmalecki@haivision.com> Co-authored-by: Jose Santiago <jsantiago@haivision.com> Co-authored-by: Thierry Lelegard <lelegard@users.noreply.github.com>

matoro added the Type: Bug Indicates an unexpected problem or unintended behavior label Mar 22, 2023

matoro added a commit to matoro/gentoo that referenced this issue Mar 22, 2023

net-libs/srt: add 1.5.1, wire up tests

71fc23e

These currently DO NOT PASS on big-endian, see Haivision/srt#2697 Bug: https://bugs.gentoo.org/900240 Signed-off-by: Matoro Mahri <matoro@users.noreply.github.com>

matoro added a commit to matoro/gentoo that referenced this issue Mar 22, 2023

net-libs/srt: add 1.5.1, wire up tests

926eece

These currently DO NOT PASS on big-endian, see Haivision/srt#2697 Bug: https://bugs.gentoo.org/900240 Signed-off-by: Matoro Mahri <matoro@users.noreply.github.com>

matoro mentioned this issue Mar 22, 2023

net-libs/srt: add 1.5.1, wire up tests gentoo/gentoo#30307

Closed

maxsharabayko added [core] Area: Changes in SRT library core [tests] Area: Unit tests labels Mar 28, 2023

maxsharabayko added this to the v1.6.0 milestone Mar 28, 2023

maxsharabayko assigned yomnes0 Mar 28, 2023

maxsharabayko mentioned this issue Mar 30, 2023

[FR] Add Big Endian to CI #2702

Closed

yomnes0 mentioned this issue Apr 3, 2023

[core] Fix peer filter config being rejected because of endianness #2708

Merged

matoro added a commit to matoro/gentoo that referenced this issue Apr 4, 2023

net-libs/srt: add 1.5.1, wire up tests

885eb6c

These currently DO NOT PASS on big-endian, see Haivision/srt#2697 Bug: https://bugs.gentoo.org/900240 Signed-off-by: Matoro Mahri <matoro@users.noreply.github.com>

matoro mentioned this issue Apr 29, 2023

[core] Correct remaining endianness issues #2729

Merged

maxsharabayko closed this as completed in #2729 May 3, 2023

maxsharabayko modified the milestones: v1.6.0, v1.5.3 Aug 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG] Test failures on big-endian #2697

[BUG] Test failures on big-endian #2697

matoro commented Mar 22, 2023

ethouris commented Apr 3, 2023

yomnes0 commented Apr 3, 2023 •

edited

Loading

maxsharabayko commented Apr 3, 2023

[BUG] Test failures on big-endian #2697

[BUG] Test failures on big-endian #2697

Comments

matoro commented Mar 22, 2023

ethouris commented Apr 3, 2023

yomnes0 commented Apr 3, 2023 • edited Loading

maxsharabayko commented Apr 3, 2023

yomnes0 commented Apr 3, 2023 •

edited

Loading