Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use overlapped WSASendTo to avoid UDP sending losses. #2632

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Use overlapped WSASendTo to avoid UDP sending losses. #2632

merged 2 commits into from
Jun 29, 2023

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Jan 26, 2023 •
edited
Loading

Added check of the WSASend result, as reported in #973.
Given that ::send(...) wan not observed to fail on Linux, adding a common ::select(...) call for both Windows and Linux might decrease the performance.
This PR uses Windows OverlappedIO API to wait for WSASend to succeed.

Fixes #973.
Closes #974 (replaces).

TODO

  • Retest.

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Jan 26, 2023
@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Jan 26, 2023
ethouris
ethouris reviewed Jan 26, 2023
View reviewed changes
srtcore/channel.cpp Outdated Show resolved Hide resolved
@ethouris ethouris mentioned this pull request Apr 3, 2023
Open
6 tasks
@maxsharabayko maxsharabayko merged commit 61c7bed into Haivision:master Jun 29, 2023
9 checks passed
@maxsharabayko maxsharabayko deleted the develop/wsasend-overlapped-v2 branch June 29, 2023 15:30
@maxsharabayko maxsharabayko modified the milestones: v1.6.0, v1.5.3 Aug 8, 2023
@maxsharabayko maxsharabayko mentioned this pull request Aug 18, 2023
Closed
guilletrejo added a commit to swxtchio/srt that referenced this pull request Aug 23, 2023
@guilletrejo @maxsharabayko
@oviano @ethouris @mbakholdina @matoro @robUx4 @aaron-jencks @gou4shi1 @xiaozhihong @yomnes0 @jlsantiago0 @lelegard
Sync to fork (#1)
a0cf944 
* [core] Fix crypto mode auto for listener sender (Haivision#2711).


Co-authored-by: oviano <ovcollyer@mac.com>

* [build] Upgraded CI: ubuntu to version 20.04 (Haivision#2682).

* [docs] Added the link for registration in slack to the getting started table (Haivision#2721).

* [core] Fixed FEC Emergency resize crash (Haivision#2717).

Fixed minimum history condition.

* [core] Fixed various compiler warnings on various platforms (Haivision#2679).

* [core] Minor fix of variable shadowing.

* [tests] Minor fix of variable shadowing.

* [build] Add -Wshadow=local to CMake build flags.
Supported since GCC 7.0.

* [core] Correct remaining endianness issues

Fixes the last two remaining test failures on big-endian.  These
operations were all already no-ops on little-endian, and unnecessarily
byteswapped the IP addresses on big-endian.

Closes: Haivision#2697

* [docs] Minor updates to AEAD docs plus changed v1.6.0 to 1.5.2 in some files

* [build] Fix downversioning of _WIN32_WINNT (Haivision#2754).

* [core] Fixed unhandled error in haicrypt (Haivision#2685).

* [core] Use overlapped WSASendTo to avoid loss in UDP sending (Haivision#2632).

* [core] Add volatile keyword to asm block in rdtsc (Haivision#2759).

* [core] Fixed srctime from closing socket was mistakenly cleared

* [core] Fixed group read-ready epoll events.

* [core] Removed unused CUDTGroup::m_Positions.

* [core] Perf improvement of group reading.

* [core] Fixed RCV buffer initialization in Rendezvous.

* [docs] Updating the explicit information for binding to IPv6 wildcard (Haivision#2765).

* [tests] Added custom main with transparent parameters for tests (Haivision#2681).

* [core] Fix memory leak when can't buffer a HS packet (Haivision#2757).

* [core] Refactor CRcvQueue::storePkt(..) for better resource management (Haivision#2775).

* [core] Fix hang up on not enough space in the RCV buffer (Haivision#2745).

When there is space available in the receiving buffer after it is full,
send an ack to allow the sender to resume transmission.
Reschedule sending if ACK decreases the flight span after sending is congested.

Co-authored-by: Maxim Sharabayko <maxlovic@gmail.com>

* [core] fix tsbpd() may deadlock with processCtrlShutdown()

* [core] Slightly optimize the RCV drop by message number (Haivision#2686).

Some minor improvements of logs and comments.

* [core] Rejection not undertaken in rendezvous after KMX failure (Haivision#2692).

* [core] Fix: In rendezvous when processing resulted in ACCEPT it was still sending rejection

* [core] Minor code clean up in CRateEstimator.

* [core] Initialize ISN and PeerISN in CUDT.

* [core] Drop unencrypted packets in GCM mode.

* [apps] Fix the build for target without IP_ADD_SOURCE_MEMBERSHIP (Haivision#2779).

* [core] Added maximum BW limit for retransmissions (Haivision#2714).

* [API] SRT version raised to 1.5.3.

* [apps] Fixed conditional IP_ADD_SOURCE_MEMBERSHIP in testmedia (Haivision#2780).

* [core] Fixed SRT_ATTR_REQUIRES use.

* [build] Added missing public header files in Windows binary installer (Haivision#2784).

The header file access_control.h was added to the source tree
at some point but was not added to the Windows installer.

---------

Co-authored-by: Maxim Sharabayko <maxlovic@gmail.com>
Co-authored-by: oviano <ovcollyer@mac.com>
Co-authored-by: Sektor van Skijlen <ethouris@gmail.com>
Co-authored-by: Maria Sharabayko <41019697+mbakholdina@users.noreply.github.com>
Co-authored-by: Maxim Sharabayko <maxsharabayko@haivision.com>
Co-authored-by: matoro <matoro@users.noreply.github.com>
Co-authored-by: Maria Sharabayko <msharabayko@haivision.com>
Co-authored-by: Steve Lhomme <robux4@ycbcr.xyz>
Co-authored-by: Aaron Jencks <32805004+aaron-jencks@users.noreply.github.com>
Co-authored-by: Guangqing Chen <hi@goushi.me>
Co-authored-by: john <hondaxiao@tencent.com>
Co-authored-by: yomnes0 <127947185+yomnes0@users.noreply.github.com>
Co-authored-by: Mikołaj Małecki <mmalecki@haivision.com>
Co-authored-by: Jose Santiago <jsantiago@haivision.com>
Co-authored-by: Thierry Lelegard <lelegard@users.noreply.github.com>
@maxsharabayko maxsharabayko mentioned this pull request Dec 15, 2023
Merged
mGaosi added a commit to mGaosi/srt that referenced this pull request Jan 22, 2024
@mGaosi
[core] Fixed thread safety using WSAOVERLAPPED in WSASendTo(Haivision…
2065b69 
…#2838).

The lpOverlapped parameter must be valid for the duration of the overlapped operation. If multiple I/O operations are simultaneously outstanding, each must reference a separate WSAOVERLAPPED structure.

This reverts commit b1c0be2.

resolves Haivision#2632 Haivision#2834 Haivision#2838
mGaosi added a commit to mGaosi/srt that referenced this pull request Jan 22, 2024
@mGaosi
[core] Fixed thread safety using WSAOVERLAPPED in WSASendTo(Haivision…
dcc8cb6 
…#2838).

The lpOverlapped parameter must be valid for the duration of the overlapped operation. If multiple I/O operations are simultaneously outstanding, each must reference a separate WSAOVERLAPPED structure.

This reverts commit b1c0be2.

resolves Haivision#973 Haivision#2632 Haivision#2834 Haivision#2838
@mGaosi mGaosi mentioned this pull request Jan 22, 2024
Closed
mGaosi added a commit to mGaosi/srt that referenced this pull request Jan 26, 2024
@mGaosi
[core] Fixed thread safety using WSAOVERLAPPED in WSASendTo(Haivision…
ed29c73 
…#2838).

The lpOverlapped parameter must be valid for the duration of the overlapped operation. If multiple I/O operations are simultaneously outstanding, each must reference a separate WSAOVERLAPPED structure.

This reverts commit b1c0be2.

resolves Haivision#973 Haivision#2632 Haivision#2834 Haivision#2838
maxsharabayko added a commit to maxsharabayko/srt that referenced this pull request Apr 16, 2024
@maxsharabayko @mGaosi
[core] Fixed thread safety using WSAOVERLAPPED in WSASendTo.
c0fdadd 
The lpOverlapped parameter must be valid for the duration of the overlapped operation.
If multiple I/O operations are simultaneously outstanding, each must reference a separate WSAOVERLAPPED structure.
Resolves Haivision#973, Haivision#2632, Haivision#2834, Haivision#2838.

Co-authored-by: Jiangjie Gao <gaojiangjie@live.com>
maxsharabayko added a commit to maxsharabayko/srt that referenced this pull request Apr 16, 2024
@maxsharabayko @mGaosi
[core] Fixed thread safety using WSAOVERLAPPED in WSASendTo.
3101c85 
The lpOverlapped parameter must be valid for the duration of the overlapped operation.
If multiple I/O operations are simultaneously outstanding, each must reference a separate WSAOVERLAPPED structure.
Resolves Haivision#973, Haivision#2632, Haivision#2834, Haivision#2838.

Co-authored-by: Jiangjie Gao <gaojiangjie@live.com>
@maxsharabayko maxsharabayko mentioned this pull request Apr 16, 2024
Merged
maxsharabayko added a commit to maxsharabayko/srt that referenced this pull request Apr 17, 2024
@maxsharabayko @mGaosi
[core] Fixed thread safety using WSAOVERLAPPED in WSASendTo.
068c5f6 
The lpOverlapped parameter must be valid for the duration of the overlapped operation.
If multiple I/O operations are simultaneously outstanding, each must reference a separate WSAOVERLAPPED structure.
Resolves Haivision#973, Haivision#2632, Haivision#2834, Haivision#2838.

Co-authored-by: Jiangjie Gao <gaojiangjie@live.com>
maxsharabayko added a commit that referenced this pull request Apr 17, 2024
@maxsharabayko @mGaosi
[core] Fixed thread safety using WSAOVERLAPPED in WSASendTo.
fd4084f 
The lpOverlapped parameter must be valid for the duration of the overlapped operation.
If multiple I/O operations are simultaneously outstanding, each must reference a separate WSAOVERLAPPED structure.
Resolves #973, #2632, #2834, #2838.

Co-authored-by: Jiangjie Gao <gaojiangjie@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethouris ethouris ethouris left review comments

Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
v1.5.3
Development

Successfully merging this pull request may close these issues.

[BUG] Check return of a non-blocking UDP send
2 participants
@maxsharabayko @ethouris