[core] Fixed thread safety using WSAOVERLAPPED in WSASendTo (Update) #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overlapped send with 100 ms timeout on Windows added a data race.
maxsharabayko
added
Type: Bug
maxsharabayko
changed the title
maxsharabayko
commented
Apr 17, 2024
maxsharabayko
force-pushed
the
hotfix/wsa
branch
from
ac55d0f
to
068c5f6
Compare
The lpOverlapped parameter must be valid for the duration of the overlapped operation. If multiple I/O operations are simultaneously outstanding, each must reference a separate WSAOVERLAPPED structure. Resolves Haivision#973, Haivision#2632, Haivision#2834, Haivision#2838. Co-authored-by: Jiangjie Gao <gaojiangjie@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ This is an update of PR #2861 by @mGaosi split into two commits: revert of PR #2834, and the re-fix of the data race.
The
lpOverlappedparameter must be valid for the duration of the overlapped operation. If multiple I/O operations are simultaneously outstanding, each must reference a separateWSAOVERLAPPEDstructure.This reverts PR #2834.
Related items: #973, #2632, #2834, #2838, #2861.
Closes #2861.