Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fixed some compiler warnings. #1669

Merged
merged 4 commits into from
Nov 24, 2020
Merged

[core] Fixed some compiler warnings. #1669

merged 4 commits into from
Nov 24, 2020

Conversation

maxsharabayko
Copy link
Collaborator

  • C4101 - local variable never used (2).
  • C4129- 'character' : unrecognized character escape sequence (1).
  • C4305 - truncation from 'type1' to 'type2' (1).

Related to #1646

@maxsharabayko
[core] Fixed some compiler warnings.
a167d11 
- C4101 - local variable never used (2).
- C4129- 'character' : unrecognized character escape sequence (1).
- C4305 - truncation from 'type1' to 'type2' (1).
@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Nov 23, 2020
@maxsharabayko maxsharabayko added this to the v1.4.3 milestone Nov 23, 2020
@maxsharabayko maxsharabayko self-assigned this Nov 23, 2020
ethouris
ethouris reviewed Nov 23, 2020
View reviewed changes
srtcore/congctl.cpp Outdated Show resolved Hide resolved
ethouris
ethouris reviewed Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@ethouris ethouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider ^^

@ethouris
Copy link
Collaborator

One more thing: core.cpp line 11187 - pending_broken should be under ENABLE_EXPERIMENTAL_BONDING

@maxsharabayko
Copy link
Collaborator Author

One more thing: core.cpp line 11187 - pending_broken should be under ENABLE_EXPERIMENTAL_BONDING

Fixed.

@codecov
Copy link

codecov bot commented Nov 23, 2020 •
edited
Loading

Codecov Report

Merging #1669 (dd8799d) into master (6e25e48) will decrease coverage by 0.59%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1669      +/-   ##
==========================================
- Coverage   60.37%   59.77%   -0.60%     
==========================================
  Files          77       77              
  Lines       17389    17387       -2     
==========================================
- Hits        10498    10393     -105     
- Misses       6891     6994     +103
Impacted Files Coverage Δ
srtcore/api.cpp 48.77% <0.00%> (+0.10%) ⬆️
srtcore/congctl.cpp 80.51% <ø> (-3.59%) ⬇️
srtcore/core.cpp 53.91% <100.00%> (-1.17%) ⬇️
test/test_listen_callback.cpp 88.00% <100.00%> (ø)
srtcore/list.cpp 66.08% <0.00%> (-13.63%) ⬇️
test/test_bonding.cpp 98.26% <0.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e25e48...dd8799d. Read the comment docs.

@maxsharabayko maxsharabayko merged commit c2f9316 into Haivision:master Nov 24, 2020
@maxsharabayko maxsharabayko deleted the hotfix/warnings-c4101 branch November 24, 2020 06:45
@maxsharabayko maxsharabayko mentioned this pull request Nov 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethouris ethouris ethouris left review comments

Assignees

@maxsharabayko maxsharabayko

Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@maxsharabayko @ethouris