Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fixed some compiler warnings. #1669

Merged
merged 4 commits into from
Nov 24, 2020
Merged

[core] Fixed some compiler warnings. #1669

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a167d11
[core] Fixed some compiler warnings.
maxsharabayko Nov 23, 2020
54df069
Replaced %% with %
maxsharabayko Nov 23, 2020
f82af09
const exception
maxsharabayko Nov 23, 2020
dd8799d
Moved pending_broken
maxsharabayko Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions srtcore/api.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ int CUDTUnited::newConnection(const SRTSOCKET listen, const sockaddr_any& peer,
{
ns->m_SocketID = generateSocketID();
}
catch (const CUDTException& e)
catch (const CUDTException&)
{
LOGF(cnlog.Fatal, "newConnection: IPE: all sockets occupied? Last gen=%d", m_SocketIDGenerator);
// generateSocketID throws exception, which can be naturally handled
Expand Down Expand Up @@ -2966,7 +2966,7 @@ void CUDTUnited::updateMux(
s->m_pUDT->m_pRcvQueue = m.m_pRcvQueue;
s->m_iMuxID = m.m_iID;
}
catch (CUDTException& e)
catch (CUDTException&)
{
m.destroy();
throw;
Expand Down
2 changes: 1 addition & 1 deletion srtcore/congctl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ class FileCC : public SrtCongestionControlBase
HLOGC(cclog.Debug, log << "FileCC: LOSS: "
<< "sent=" << CSeqNo::seqlen(m_iLastAck, m_parent->sndSeqNo()) << ", inFlight=" << pktsInFlight
<< ", lost=" << numPktsLost << " ("
<< lost_pcent_x10 / 10 << "." << lost_pcent_x10 % 10 << "\%)");
<< lost_pcent_x10 / 10 << "." << lost_pcent_x10 % 10 << "%%)");
maxsharabayko marked this conversation as resolved.
Show resolved Hide resolved
if (lost_pcent_x10 < 20) // 2.0%
{
HLOGC(cclog.Debug, log << "FileCC: LOSS: m_dLastDecPeriod=" << m_dLastDecPeriod << "->" << m_dPktSndPeriod);
Expand Down
2 changes: 1 addition & 1 deletion test/test_listen_callback.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ int SrtTestListenCallback(void* opaq, SRTSOCKET ns, int hsversion, const struct

static const char stdhdr [] = "#!::";
uint32_t* pattern = (uint32_t*)stdhdr;
bool found = -1;
bool found = false;

if (strlen(streamid) > 4 && *(uint32_t*)streamid == *pattern)
{
Expand Down