[core] Fixed RCV TL drop of packets dropped by SND #2214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The receiver buffer may have packets dropped by sender (marked as
EntryState_Drop
).In that case, the ACK position is likely ahead of the current reading position. This has to be taken into account in the TSBPD thread.
It can result in the receiver hanging up for a couple of seconds, making the sender break the connection.
SRTT + 4 x RTTVar
: it now results in tens of seconds. Therefore, the receiver waits for tens of seconds before concluding the connection with the sender is broken. The SHUTDOWN control packet from the sender is probably lost in that case.This PR Changes
CRcvBufferNew::dropUpTo(..)
now returns the number of packets actually dropped. This value is used to update the RCV drop statistics.m_iRcvLastSkipAck
happens only if dropping ahead of the current ACK position. Loss lists update as well.CUDT::dropTooLate(int upTo)
.pktRcvDrop
andpktRcvDropTotal
.