Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fixed build with the old RCV buffer #2215

Merged

Conversation

maxsharabayko
Copy link
Collaborator

The new function CUDT::dropTooLateUpTo(..) added in PR #2214 is expected to work only with the new receiver buffer, thus breaking the build if the old receiver buffer is enabled.
This PR enables the function only if the new receiver buffer is used.

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Dec 26, 2021
@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Dec 26, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2215 (160af39) into master (1111cbd) will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2215      +/-   ##
==========================================
+ Coverage   65.60%   65.66%   +0.05%     
==========================================
  Files          95       95              
  Lines       19489    19489              
==========================================
+ Hits        12786    12797      +11     
+ Misses       6703     6692      -11     
Impacted Files Coverage Δ
srtcore/core.cpp 59.31% <0.00%> (-0.29%) ⬇️
srtcore/core.h 79.01% <ø> (ø)
srtcore/window.cpp 81.81% <0.00%> (-1.30%) ⬇️
srtcore/buffer_rcv.cpp 66.50% <0.00%> (-0.25%) ⬇️
srtcore/api.cpp 51.37% <0.00%> (-0.22%) ⬇️
srtcore/buffer.cpp 65.36% <0.00%> (+0.60%) ⬆️
srtcore/congctl.cpp 80.72% <0.00%> (+1.56%) ⬆️
srtcore/queue.cpp 81.27% <0.00%> (+1.59%) ⬆️
srtcore/list.cpp 75.34% <0.00%> (+3.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1111cbd...160af39. Read the comment docs.

@maxsharabayko maxsharabayko merged commit 3d26644 into Haivision:master Dec 27, 2021
@maxsharabayko maxsharabayko deleted the hotfix/old-rcvbuf-build branch December 27, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants