[MAINT] Fixed wrong null-safety condition check in haicrypt #2616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
Type: Maintenance
Given SRT is C++, using C99 should not be a problem for the project itself. And I guess the library is no longer used alone. @jeandube Please approve the changes. |
jeandube
suggested changes
Jan 23, 2023
ethouris
commented
Jan 24, 2023
| @@ -149,11 +144,6 @@ int HaiCrypt_Tx_Process(HaiCrypt_Handle hhc, | |||
| /* Manage Key Material (refresh, announce, decommission) */ | |||
| hcryptCtx_Tx_ManageKM(crypto); | |||
|
|
|||
There was a problem hiding this comment.
@jeandube : Note that I'm taking it as a good deal that the call to hcryptCtx_Tx_ManageKM doesn't modify the assignment of crypto->ctx; as far as I could check it, it shouldn't.
maxsharabayko
approved these changes
Jan 25, 2023
|
Looks good to me. |
jeandube
approved these changes
Jan 25, 2023
This was referenced Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2376
IMPORTANT: Since this version C99 is the minimum standard required for compiling haicrypt.