Added API to get instantaneous stats instead of moving averages for a… #288
Conversation
…pps requiring faster reaction to network condition changes. Removed extraneous handshakeDone() call preventing connection to peers running older SRT versions.
srtcore/core.cpp
Outdated
| #ifdef SRT_ENABLE_SNDBUFSZ_MAVG | ||
| perf->pktSndBuf = m_pSndBuffer->getAvgBufSize(Ref(perf->byteSndBuf), Ref(perf->msSndBuf)); | ||
| if (instantaneous | ||
| || ((perf->pktSndBuf == 0x5AE) && (perf->msSndBuf ==0x5AE))){ //5AE: SRT Adapted Encoding: Preserve historical API to get instantaneous stats |
There was a problem hiding this comment.
Could you please add more explanation in form of code comments on 0x5AE magic?
Also is this endian-safe?
There was a problem hiding this comment.
Before the API was changed to add the instantaneous param, and because of lazy programming, the perf structure was used as and IN and OUT param to enable the "instantaneous" behavior. The value 0x5Ae is just a signature set in 2 fields to lower the probability of accidental stack junk setting. I hope this comment will stay for history as much as a comment would be and save me from redoing another PR.
There was a problem hiding this comment.
If there's a chance for a singular value ("stack junk") in this structure, then maybe we need to somehow initialize it?
There was a problem hiding this comment.
I would vote for removing the magic if it is already deprecated. @jeandube let me know if you agree and I will push the change.
* dev: (21 commits) Fix SRT file transmit app to work in non-blocking mode (Haivision#334) Ensure stdout silence in console pipe out mode plus a few minor fixups (Haivision#275) Replaced hardcoded installdirs with GNUInstallDirs. Fixed some status messages. (Haivision#323) Breaking connection when recv buffer inflation caused sequence discrepancy (Haivision#300) Fixed problems with encryption decision and status report on encryption failure. (Haivision#318) Fixed invalid symbol names in doc (Haivision#311) Dev add version to winpackages (Haivision#328) Android build for dev (Haivision#326) Change License to MPLv2.0 (Haivision#327) Used constants for input rate. Fixed after-start rate sampling period to 1s (Haivision#315) Made SockaddrToString use only numeric string by default (Haivision#312) Ported change in Haivision#307 PR to dev Fixed SockaddrToString to format as 4dotIP if unknown (Haivision#299) Build with debug information for lldb on iOS platform (Haivision#302) Fix for sudden stop sending data on macOS/iOS (Haivision#303) Fix broken build when testing apps enabled (Haivision#296) Removed all code introduced for CBR (Haivision#293) Added API to get instantaneous stats instead of moving averages for a… (Haivision#288) Added toolchain file and build instruction for iOS (Haivision#286) Fix windows build (Haivision#290) ...
…pps requiring faster reaction to network condition changes.
Removed extraneous handshakeDone() call preventing connection to peers running older SRT versions.