Replaced hardcoded installdirs with GNUInstallDirs. Fixed some status msgs #323
Conversation
|
As per #313 |
| if (CYGWIN) | ||
| set (INSTALL_SHARED_DIR bin) | ||
| set (INSTALL_SHARED_DIR ${CMAKE_INSTALL_BINDIR}) |
There was a problem hiding this comment.
Isn't this not set if you dont use GNUInstalldirs?
There was a problem hiding this comment.
But I do use GNUInstallDirs, unless CMAKE_INSTALL_LIBDIR is set. I state all others are set then as well.
| # inside "bin" and "lib64" directories. At least this maintains | ||
| # the current status. Shall this be not desired, override values | ||
| # of CMAKE_INSTALL_BINDIR, CMAKE_INSTALL_LIBDIR and CMAKE_INSTALL_INCLUDEDIR. | ||
| if (NOT DEFINED CMAKE_INSTALL_LIBDIR) |
There was a problem hiding this comment.
You may want to just disable it on Windows and enable everywhere else? You want to also replace include/ etc
There was a problem hiding this comment.
I was thinking about it, but actually I have never seen any "installing standards" on Windows, especially as it comes to libraries, and GNUInstallDirs works on Windows as well. AFAIK cmake on Windows allows it to install in C:\Program Files or kinda like that, followed by the project name and then inside this directory the GNU directory layout is as good as any other. I've moved these platform dependent variables just for that purpose, but then I finally came to the conclusion as described in the above comment.
* dev: (21 commits) Fix SRT file transmit app to work in non-blocking mode (Haivision#334) Ensure stdout silence in console pipe out mode plus a few minor fixups (Haivision#275) Replaced hardcoded installdirs with GNUInstallDirs. Fixed some status messages. (Haivision#323) Breaking connection when recv buffer inflation caused sequence discrepancy (Haivision#300) Fixed problems with encryption decision and status report on encryption failure. (Haivision#318) Fixed invalid symbol names in doc (Haivision#311) Dev add version to winpackages (Haivision#328) Android build for dev (Haivision#326) Change License to MPLv2.0 (Haivision#327) Used constants for input rate. Fixed after-start rate sampling period to 1s (Haivision#315) Made SockaddrToString use only numeric string by default (Haivision#312) Ported change in Haivision#307 PR to dev Fixed SockaddrToString to format as 4dotIP if unknown (Haivision#299) Build with debug information for lldb on iOS platform (Haivision#302) Fix for sudden stop sending data on macOS/iOS (Haivision#303) Fix broken build when testing apps enabled (Haivision#296) Removed all code introduced for CBR (Haivision#293) Added API to get instantaneous stats instead of moving averages for a… (Haivision#288) Added toolchain file and build instruction for iOS (Haivision#286) Fix windows build (Haivision#290) ...
No description provided.