Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{FEC} Random refactoring and small bugfixes during FEC works. #852

Merged
merged 4 commits into from
Sep 6, 2019
Merged

{FEC} Random refactoring and small bugfixes during FEC works. #852

merged 4 commits into from
Sep 6, 2019

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Sep 4, 2019

List of fixes:

  • Added official (lacking) option --enable-unittests to configure-data.tcl
  • Formatting fixes and new log entries
  • Added testing entry in channel.cpp to allow configure a fake packet loss
  • Extra comments
  • Better use of conditional IF_HEAVY_LOGGING for evaluations used for heavy logging only
  • Fix: added error handling for setupCC that results in rejection
  • Refax: packet content reporting function for logs
  • Log support improvement: pairs and containers displayed with Printable
  • New BufferStamp functions that allows putting a short string in the log that can report contents of a larger payload
  • Minor new utilities

@ethouris ethouris changed the title Random refactoring and small bugfixes during FEC works. {FEC} Random refactoring and small bugfixes during FEC works. Sep 4, 2019
@ethouris ethouris added this to the v1.4.0 milestone Sep 5, 2019
@ethouris ethouris added [build] Area: Changes in build files [core] Area: Changes in SRT library core Priority: Critical Status: Review Needed labels Sep 5, 2019
@ethouris ethouris requested a review from rndi September 5, 2019 06:55
@ethouris ethouris added [docs] Area: Improvements or additions to documentation Type: Maintenance Work required to maintain or clean up the code labels Sep 5, 2019
@ethouris
Copy link
Collaborator Author

ethouris commented Sep 5, 2019

BLOCKS: #854

rndi
rndi suggested changes Sep 5, 2019
View reviewed changes
Mikołaj Małecki and others added 2 commits September 5, 2019 18:53
@rndi rndi merged commit 9b01aac into Haivision:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndi rndi rndi requested changes

Assignees
No one assigned
Labels
[build] Area: Changes in build files [core] Area: Changes in SRT library core [docs] Area: Improvements or additions to documentation Priority: Critical Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ethouris @rndi