{FEC} Packet filter framework and API #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
[core]
|
BLOCKS: #855 |
rndi
suggested changes
Sep 5, 2019
added 3 commits
September 6, 2019 09:06
…lity set definition. Recorded SRT HS flags in the fields.
rndi
reviewed
Sep 6, 2019
| SRTO_KMREFRESHRATE, // After sending how many packets the encryption key should be flipped to the new key | ||
| SRTO_KMPREANNOUNCE, // How many packets before key flip the new key is annnounced and after key flip the old one decommissioned | ||
| SRTO_STRICTENC, // Connection to be rejected or quickly broken when one side encryption set or bad password | ||
| SRTO_IPV6ONLY, // IPV6_V6ONLY mode | ||
| SRTO_PEERIDLETIMEO, // Peer-idle timeout (max time of silence heard from peer) in [ms] | ||
| // (some space left) | ||
| SRTO_PACKETFILTER = 60 // Add and configure a packet filter |
There was a problem hiding this comment.
What is the purpose of leaving some space here?
There was a problem hiding this comment.
Avoiding collision with other ongoing work. New options are being added lately very often.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
((NOTE: DON'T REVIEW UNTIL PARENT MERGED: pf-fec-core-prefax))