Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix killer door textures #1177

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Conversation

vaguerant
Copy link
Contributor

@vaguerant vaguerant commented Aug 13, 2022

Workaround to fix #263.

This may not be the ideal solution. #616 proposes reinstating the original N64 object dependency, but that has its own drawbacks, like crashes when using wrong-age equipment.

I think no matter what the solution ends up being, it will probably involve making hotfixes to various behaviors. It's either workarounds for issues caused by the current behavior, or undo object dependency changes and make workarounds for the issues caused by that instead.

Left a comment noting the workaround, ala the similar #615.

EDIT: Additional note:

As far as I know, fake doors only appear in the Fire Temple (where they use the HIDAN [Fire Temple] metal door texture), Spirit Temple and Gerudo Training Ground (where they use the default GAMEPLAY_KEEP wooden door texture).

The killer door object is also set up to handle using the MIZU (Water Temple) and HAKA (Shadow Temple) textures even though they don't seem to occur in those areas. Maybe they do appear in Master Quest, or maybe they were removed from those areas during development, or maybe they were just covering their bases in case they ever did want to use them.

This workaround replicates that original behavior, so fake doors should display with dungeon-appropriate textures if forcibly spawned in those locations.

@Kenix3
Copy link
Collaborator

Kenix3 commented Aug 15, 2022

This may not be the ideal solution. #616 proposes reinstating the original N64 object dependency, but that has its own drawbacks, like crashes when using wrong-age equipment.

I'd rather have authentic behaviour, even if it means that Child Link can't use Hookshot and Adult Link can't use Deku Sticks. The proposal in #616 is definitely the right answer. If we really want to keep those special cases, we can load the Adult and Child objects at all times.

@briaguya-ai
Copy link
Contributor

since we decided against bringing back authentic object dependency this can go in

@briaguya-ai briaguya-ai merged commit 76942ae into HarbourMasters:develop Oct 21, 2022
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this pull request Nov 28, 2022
* Fix killer door textures

* Remove todo as requested by @Rozelette
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this pull request Nov 28, 2022
* Fix killer door textures

* Remove todo as requested by @Rozelette
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this pull request Nov 28, 2022
* Fix killer door textures

* Remove todo as requested by @Rozelette
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this pull request Nov 28, 2022
* Fix killer door textures

* Remove todo as requested by @Rozelette
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spirit Temple Boss key room fake doors are inaccurate
3 participants