-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Enable rumble thread #189
Conversation
Signed-off-by: Thomas Rohloff <v10lator@myway.de>
Signed-off-by: Thomas Rohloff <v10lator@myway.de>
Signed-off-by: Thomas Rohloff <v10lator@myway.de>
This does not work in its current state, it doesn't seem like |
Thanks for the feedback. To the maintainers: Should I break this pull request into two with the first one having the fixes only? That would allow to add the fixes while we still figure out why the thread won't start. |
Also to the maintainers: The decomp fixed the thread stacks on their end, too: zeldaret/oot@93096a4#diff-fe40752b17d8d7a41914b7ce858cfade82a6ce155bbb19c3aa05331103ea322eL79 - So maybe it would be a better idea to sync with upstream than to apply my fix? |
After looking into it more closely the reason this doesn't work is because |
As Sirius mentioned, the thread doesn't start because the libultraship doesn't expose a reimplementation for osCreateThread. Up to you if you want to split or not. The correct solution here, though is for libultraship to expose osCreateThread. |
…ilds-for-now come on mac all i want you to be is a text file
This is currently untested as I can't compile but it should fix random crashes as well as #183