Workaround for #183 #284
Merged
Workaround for #183 #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osStartThread: Yes. Else the thread will get created but not run. |
Kenix3
approved these changes
May 15, 2022
V10lator
pushed a commit
to V10lator/Shipwright
that referenced
this pull request
May 16, 2022
V10lator
added a commit
to V10lator/Shipwright
that referenced
this pull request
May 17, 2022
…rMasters#284)"" This reverts commit 8dee1e8.
Malkierian
pushed a commit
to Malkierian/Shipwright
that referenced
this pull request
Nov 20, 2023
This is where it is actually used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a workaround that closes #183 by updating the controllers 3 times as often in its current call site. Eventually the proper fix would be implementing os thread functions as laid out in #189 by Kenix and then allowing controller inputs to be read in a separate thread, but this works well enough for now from what I can see.
Edit: Alternatively I could just implement
osCreateThreadin this PR but I'm not entirely sure the proper way to implement it considering the thread parameters may need to be handled. Also wouldosStartThreadandosStopThreadneed to be implemented too in that case?