-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add voice tab to Audio Editor #3080
Add voice tab to Audio Editor #3080
Conversation
Todo: rename rest of entries and reorganize it into a new tab
Also make it, it's own tab. Added the option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far. Are you wrapped up on this or do you intend on continuing to iterate?
Co-authored-by: Garrett Cox <garrettjcox@gmail.com>
This is fine for a v1 of this since I have no idea on how to fix the SFX_FLAG issue and the other thing I need is a way to shuffle both sfx and voice pools together which #2714 has but I saw your new comment on it so hopefully a more general solution is made. I mainly did this for the funny Link voice shuffle. |
Todo:
This adds a new tab to the audio editor called voices:
![image](https://private-user-images.githubusercontent.com/12226010/253480415-015814aa-320d-470c-8f87-0f6125330df5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NTgxMjIsIm5iZiI6MTczODk1NzgyMiwicGF0aCI6Ii8xMjIyNjAxMC8yNTM0ODA0MTUtMDE1ODE0YWEtMzIwZC00NzBjLThmODctMGY2MTI1MzMwZGY1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDE5NTAyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNlMjJmNzJlYTk5MmFmNjM3MWYyYThhZjE3OGI4ZDhlMTI0YmMyZGU4NTU0YmViNWJjNjg5MGE0ZjA3MmZlZTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.-fFXFc7tdDTbYHcY95mYnzEcBdp62SQniCEaVB7ZTTo)
Includes every voice that that the game considers a voice, based on being named VO note that means any enemy sound effects that are voices don't count for this. This includes child and adult link voices as well as npcs.
Build Artifacts