TWEAK: Add transition to the Time Travel feature #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
reviewed
Oct 11, 2023
Archez
approved these changes
Oct 11, 2023
briaguya-ai
approved these changes
Oct 11, 2023
|
might be worth making a code cleanup issue to move away from magic numbers for transitions, definitely not something that needs to be a part of this PR |
Decomp has you covered https://github.com/zeldaret/oot/blob/main/include/z64transition.h |
garrettjoecox
approved these changes
Oct 15, 2023
garrettjoecox
added a commit
that referenced
this pull request
Oct 16, 2023
* typo on asset attribute for pal1.1 (#3264) * typo on asset attribute * base address fix * [Cosmetic] Adds Bunny Hood to Cosmetic Editor (#3245) * Color and Invisible Checkbox GI model crashes when talking to mask salesman * Update z_player.c Co-authored-by: Garrett Cox <garrettjcox@gmail.com> * Update z_player.c Co-authored-by: Garrett Cox <garrettjcox@gmail.com> * Move bunny hood coloring to patch --------- Co-authored-by: Garrett Cox <garrettjcox@gmail.com> * redicle -> reticle (#3257) * Equip Tunic and Boots while performing most actions (#3239) * tunics and boot equips initial todo: find an appropriate place to first put Player_AssignTunicBoots * move to more appropriate place * assign -> use * [Difficulty Options] All Dogs are Richard (#3243) * Oops, all Richards! * Sure is * Randomizer - Colored hints (#3259) * Colored hints * Missed 2 french translations * add save editor field for current b button item (#3262) * TWEAK: Add transition to the Time Travel feature (#3276) * ADD/ Proper Transition * REM: Dupe * MM Bunny Hood effect separated from ability to equip as adult (#3253) * adult separator * use cross instead of checkmark Co-authored-by: Garrett Cox <garrettjcox@gmail.com> * suggested load fix --------- Co-authored-by: Garrett Cox <garrettjcox@gmail.com> --------- Co-authored-by: Adam Bird <Archez@users.noreply.github.com> Co-authored-by: Patrick12115 <115201185+Patrick12115@users.noreply.github.com> Co-authored-by: inspectredc <78732756+inspectredc@users.noreply.github.com> Co-authored-by: aMannus <mannusmenting@gmail.com> Co-authored-by: PurpleHato <linkvssangoku.jr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a tiny touch-up that I should have included from the start for this feature
Before:
TT1.mp4
After:
TT2.mp4
Build Artifacts