Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrades axios #634

Merged
merged 3 commits into from
May 10, 2024
Merged

chore: Upgrades axios #634

merged 3 commits into from
May 10, 2024

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Apr 10, 2024

Acceptance Criteria

  • Upgrades axios from 0.21.4 to 1.6.8

Notes

Some resources claim that no changes are necessary to update this major version, while others claim entire migration guides are required. For this repository no changes were necessary.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the dependencies Pull requests that update a dependency file label Apr 10, 2024
@tuliomir tuliomir self-assigned this Apr 10, 2024
@tuliomir tuliomir changed the base branch from master to chore/upgrades-nodejs May 2, 2024 12:16
@tuliomir tuliomir marked this pull request as ready for review May 2, 2024 15:44
@tuliomir tuliomir marked this pull request as draft May 2, 2024 16:14
Base automatically changed from chore/upgrades-nodejs to master May 4, 2024 00:00
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.48%. Comparing base (37050ff) to head (92c6ff1).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #634       +/-   ##
===========================================
+ Coverage   62.01%   79.48%   +17.47%     
===========================================
  Files          77       77               
  Lines        5826     5826               
  Branches     1223     1210       -13     
===========================================
+ Hits         3613     4631     +1018     
+ Misses       2116     1178      -938     
+ Partials       97       17       -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuliomir tuliomir marked this pull request as ready for review May 8, 2024 13:55
@tuliomir tuliomir requested review from alexruzenhack and r4mmer and removed request for pedroferreira1 May 8, 2024 13:55
@tuliomir tuliomir merged commit cef19d9 into master May 10, 2024
4 checks passed
@tuliomir tuliomir deleted the chore/upgrades-axios branch May 10, 2024 16:36
This was referenced May 16, 2024
@tuliomir tuliomir mentioned this pull request Jun 11, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants