chore: Upgrades minors and patches #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #665 +/- ##
===========================================
+ Coverage 62.79% 79.73% +16.93%
===========================================
Files 77 77
Lines 5886 5886
Branches 1229 1229
===========================================
+ Hits 3696 4693 +997
+ Misses 2094 1176 -918
+ Partials 96 17 -79 ☔ View full report in Codecov by Sentry. |
tuliomir
commented
Jun 12, 2024
Comment on lines
+57
to
+58
| const long = Long.fromNumber(value, false); | ||
| arr = new Uint8Array(long.toBytesBE()).buffer; |
There was a problem hiding this comment.
The implicit conversion from number[] to ArrayBuffer was being rejected by the build phase ( failed action )
An explicit conversion was implemented through Uint8Array, and according to the unit tests is working correctly.
r4mmer
previously approved these changes
Jun 12, 2024
tuliomir
force-pushed
the
chore/upgrades-minors
branch
from
9ae3f43
to
67c2bfc
Compare
r4mmer
approved these changes
Jun 12, 2024
pedroferreira1
approved these changes
Jun 17, 2024
tuliomir
force-pushed
the
chore/upgrades-minors
branch
from
67c2bfc
to
57c64b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
axiosfrom1.6.8to1.7.2( a continuation of chore: Upgradesaxios#634 )axios-mock-adapterfrom1.17.0to1.22.0( same here )levelfrom8.0.0to8.0.1longfrom4.0.0to5.2.3( the release notes says it's only a refactor )Notes
Following a suggestion from @r4mmer I have tested the built lib on both the Desktop and Headless wallets to ensure the browser and node environments correctly handle the
Uint8Arraycode change as well.The manual test on the Desktop wallet worked correctly and the full integration tests suite on the headless also passed.
Security Checklist