feat: add cleanTokens to new/wallet #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
===========================================
+ Coverage 62.48% 79.63% +17.14%
===========================================
Files 77 77
Lines 5838 5838
Branches 1227 1214 -13
===========================================
+ Hits 3648 4649 +1001
+ Misses 2093 1172 -921
+ Partials 97 17 -80 ☔ View full report in Codecov by Sentry. |
alexruzenhack
commented
May 10, 2024
| @@ -36,13 +36,13 @@ describe('handleStop', () => { | |||
| it('should work with memory store', async () => { | |||
| const store = new MemoryStore(); | |||
| await handleStopTest(store); | |||
| }, 10000); | |||
There was a problem hiding this comment.
I have had to increase the timeout to make the test pass on the CI process.
Merged
1 task
pedroferreira1
approved these changes
May 13, 2024
r4mmer
approved these changes
May 14, 2024
alexruzenhack
force-pushed
the
feat/add-cleanTokens-to-stop
branch
from
afc704a
to
904bfd1
Compare
This was referenced May 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
stopmethodSecurity Checklist