fix: remove registered tokens when changing network settings #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
approved these changes
May 2, 2024
pedroferreira1
force-pushed
the
release-candidate
branch
from
f3c0a5c
to
f88c2bf
Compare
alexruzenhack
force-pushed
the
fix/clean-tokens-network-change
branch
from
d3bcfad
to
2a95261
Compare
andreabadesso
requested changes
May 24, 2024
andreabadesso
approved these changes
May 24, 2024
| * @async | ||
| * @returns {Promise<void>} | ||
| */ | ||
| async cleanStorage(cleanHistory = false, cleanAddresses = false, cleanTokens = false) { |
There was a problem hiding this comment.
Why do you need this method?
There was a problem hiding this comment.
Oh, this is needed to also clean the app's AsyncStorage managed by the HybridStore.
pedroferreira1
approved these changes
May 28, 2024
andreabadesso
pushed a commit
that referenced
this pull request
Jun 24, 2024
* fix: remove registered tokens when changing network settings * feat: it extends HibridStore cleanStorage to also clean the cache * feat: remove cleanStorage and add cleanTokens when calling wallet.stop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
It depends on:
Security Checklist