Fix: QR Code registered token check #386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In two places the application was trying to check if a token was registered by querying the wallet storage object directly. However, this low level storage does not contain the default token, and that lead to false negative responses.
There are other higher level helper sources that already take these implicit default tokens into consideration: those should be used instead. Namely, the
getRegisteredTokens
saga helper function and the redux statetokens
property.Acceptance Criteria
Security Checklist