Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: QR Code registered token check #386

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Fix: QR Code registered token check #386

merged 3 commits into from
Nov 16, 2023

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Nov 14, 2023

In two places the application was trying to check if a token was registered by querying the wallet storage object directly. However, this low level storage does not contain the default token, and that lead to false negative responses.

There are other higher level helper sources that already take these implicit default tokens into consideration: those should be used instead. Namely, the getRegisteredTokens saga helper function and the redux state tokens property.

Acceptance Criteria

  • Registered tokens should be read from the helper functions

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the bug Something isn't working label Nov 14, 2023
@tuliomir tuliomir self-assigned this Nov 14, 2023
@tuliomir tuliomir removed the request for review from pedroferreira1 November 14, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants