-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: QA steps to validate QR Code scanner #387
Conversation
QA.md
Outdated
1. Take a screenshot of the QR Code and open that screenshot in another device | ||
1. Use the Mobile Wallet QR code scanner to read this screenshot | ||
1. Pay the Payment Request using the same wallet used to generate it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds very confusing to me
Since we are validating the QR Code scan (the QR Code itself is already being tested in another step), we can just change it to something like:
1. Take a screenshot of the QR Code and open that screenshot in another device | |
1. Use the Mobile Wallet QR code scanner to read this screenshot | |
1. Pay the Payment Request using the same wallet used to generate it | |
1. Generate a payment request requesting a payment of 1 HTR from another device | |
1. Use the Mobile Wallet QR code scanner to read this screenshot | |
1. Pay the Payment Request, the transaction should be successful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good idea. Changed the wording on bfa0c65.
bf4e55f
to
ac71d21
Compare
ac71d21
to
bfa0c65
Compare
Recently we found some errors ( fixed by #384 and #386 ) that only happened during QR Code scanning. This procedure should also be on the main QA.
Acceptance Criteria
Security Checklist