Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stochastic using solver (4 PRs) #64

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Stochastic using solver (4 PRs) #64

merged 2 commits into from
Apr 18, 2024

Conversation

Whebon
Copy link
Contributor

@Whebon Whebon commented Apr 10, 2024

Makes rulenode2expr compatible with any AbstractRuleNode. In particular, StateFixedShapedHoles (renamed to: StateHole) can now be converted to an expression.

@ReubenJ
Copy link
Member

ReubenJ commented Apr 12, 2024

Tests pass locally, waiting on HerbCore.jl#17 and the version 0.3.0 release

  • update this branch with correct naming of HerbCore types (can rebase this branch on top of dev or merge/cherry-pick da00007)

@ReubenJ
Copy link
Member

ReubenJ commented Apr 18, 2024

Rebased on top of dev and cleaned up commit history. Tested locally with all other dev branches.

Copy link
Member

@ReubenJ ReubenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your work!

@ReubenJ ReubenJ merged commit ec7aa9b into dev Apr 18, 2024
0 of 2 checks passed
@ReubenJ ReubenJ deleted the stochastic-using-solver branch April 18, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants