Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.3.0 #17

Merged
merged 36 commits into from
Apr 25, 2024
Merged

Bump version to 0.3.0 #17

merged 36 commits into from
Apr 25, 2024

Conversation

ReubenJ
Copy link
Member

@ReubenJ ReubenJ commented Apr 12, 2024

This version adds:

  • AbstractHole to support multiple hole types
  • Hole, which existed before as the abstract Hole type, but is now the basic, concrete hole type
  • AbstractUniformHole
  • UniformHole
  • get_path
  • number_of_holes
  • contains_nonuniform_hole
  • get_children
  • get_rule
  • isuniform
  • isfilled
  • hasdynamicvalue
  • have_same_shape

And changes:

  • Constraint -> AbstractConstraint

Addresses #12

@ReubenJ ReubenJ marked this pull request as ready for review April 12, 2024 10:10
@ReubenJ ReubenJ marked this pull request as draft April 12, 2024 12:23
@ReubenJ ReubenJ marked this pull request as draft April 15, 2024 12:06
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 55.08982% with 75 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@904543a). Click here to learn what that means.

Files Patch % Lines
src/rulenode.jl 55.08% 75 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #17   +/-   ##
=========================================
  Coverage          ?   54.59%           
=========================================
  Files             ?        2           
  Lines             ?      185           
  Branches          ?        0           
=========================================
  Hits              ?      101           
  Misses            ?       84           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReubenJ ReubenJ marked this pull request as ready for review April 15, 2024 14:03
@THinnerichs THinnerichs merged commit b8e747b into master Apr 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants