Skip to content

Commit

Permalink
Fix capitalisation of Heroic in GlobalState.tsx (#4218)
Browse files Browse the repository at this point in the history
* Fix capitalisation of Heroic in GlobalState.tsx

I noticed it while translating.

* More capitalization fixes
  • Loading branch information
LenaWil authored Jan 22, 2025
1 parent 0b5e402 commit 78f9388
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion e2e/webview_controls.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { WebviewTag } from 'electron'
electronTest('webview', async (app) => {
const page = await app.firstWindow()

await test.step('goes back and forth inside webview and also to heroic screens', async () => {
await test.step('goes back and forth inside webview and also to Heroic screens', async () => {
// we have to do this or it fails, the icon also has the same text
await page.locator('span').filter({ hasText: 'Documentation' }).click()

Expand Down
4 changes: 2 additions & 2 deletions public/locales/en/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
},
"reset-heroic": {
"question": {
"message": "Are you sure you want to reset Heroic? This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of heroic needs to be restarted manually afterwards.",
"message": "Are you sure you want to reset Heroic? This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of Heroic needs to be restarted manually afterwards.",
"title": "Reset Heroic"
}
},
Expand Down Expand Up @@ -764,7 +764,7 @@
},
"details": "Details",
"resetHeroic": {
"help": "This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of heroic needs to be restarted manually afterwards."
"help": "This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of Heroic needs to be restarted manually afterwards."
},
"title": {
"clearCache": "Clear Cache",
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/helpers/gamepad.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export const initGamepad = () => {
if (controllerIsDisabled) return

if (!isFocused) {
// ignore gamepad events if heroic is not the focused app
// ignore gamepad events if Heroic is not the focused app
//
// the browser still detects the gamepad interactions even
// if the screen is not focused when playing a game
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/helpers/shortcuts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const initShortcuts = () => {
// Ctrl+L or Cmd+L, show library
// Ctrl+J or Cmd+J, download manager
// Ctrl+K or Cmd+K, settings
// Ctrl+Q or Cmd+Q, quit heroic
// Ctrl+Q or Cmd+Q, quit Heroic
if (['r', 'j', 'k', 'l', 'q'].includes(e.key)) {
window.api.processShortcut(`ctrl+${e.key}`)
}
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/screens/Settings/components/ResetHeroic.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const ResetHeroic = () => {
<InfoBox text={t('settings.advanced.details', 'Details')}>
{t(
'settings.advanced.resetHeroic.help',
"This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of heroic needs to be restarted manually afterwards."
"This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of Heroic needs to be restarted manually afterwards."
)}
</InfoBox>
<button className="button is-footer is-danger" onClick={showResetDialog}>
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/state/GlobalState.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ class GlobalState extends PureComponent<Props> {
title: t('box.reset-heroic.question.title', 'Reset Heroic'),
message: t(
'box.reset-heroic.question.message',
"Are you sure you want to reset Heroic? This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of heroic needs to be restarted manually afterwards."
"Are you sure you want to reset Heroic? This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of Heroic needs to be restarted manually afterwards."
),
buttons: [
{ text: t('box.yes'), onClick: window.api.resetHeroic },
Expand Down

0 comments on commit 78f9388

Please sign in to comment.