-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix capitalisation of Heroic in GlobalState.tsx #4218
Conversation
I noticed it while translating.
Am I stupid, or should e2e not fail? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to run pnpm i18n
so it updates the locale json file
I did, but |
I see, it's because the key didn't change so |
@arielj Can you review again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
I noticed it while translating.
Use the following Checklist if you have changed something on the Backend or Frontend: