Vertical Scrollable List Fragment #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanodeath
force-pushed
the
scrollable-controls
branch
3 times, most recently
from
ff44c78 to
32af8e9
Compare
nanodeath
force-pushed
the
scrollable-controls
branch
from
32af8e9 to
d992f8a
Compare
|
Ready for review, assuming the CircleCI build succeeds. Open questions are still open though! |
adam-arold
approved these changes
Apr 24, 2021
| @@ -168,6 +167,20 @@ abstract class BaseScrollBar( | |||
| } else Pass | |||
| } | |||
|
|
|||
| override fun mouseWheelRotatedUp(event: MouseEvent, phase: UIEventPhase): UIEventResponse { | |||
| @@ -8,10 +8,12 @@ import org.hexworks.zircon.api.data.Position | |||
| import org.hexworks.zircon.api.data.Tile | |||
| import org.hexworks.zircon.api.graphics.TileGraphics | |||
|
|
|||
| @Suppress("DuplicatedCode") | |||
| class VerticalScrollBarRenderer : ComponentRenderer<ScrollBar> { | |||
| open class VerticalScrollBarRenderer internal constructor() : ComponentRenderer<ScrollBar> { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible implementation for the Vertical Scrollable List thing in #372.
I've refactored a lot of the previous work found in ScrollBarExample.kt into a reusable Fragment. I also implemented some bug fixes in the scrollbar implementation itself, but I tried to keep these minimal to not pollute the PR, but for example in tiny scroll bars (height 2 for example) the bar doesn't render at all, when it should render with height 1.
I've included a shiny new vaguely-named
TestRendererthat lets me render the entire component stack and trigger events. It shouldn't really be in this PR, as it's not related to the new component, but it's at least a separate commit.I've also updated ScrollBarExample to use the new fragment.
Happy to incorporate suggestions.
Open Questions
Fragments.newVerticalScrollableList()pattern going, to complementComponents?VerticalScrollableListacceptable, or are they indicative of a fundamental problem?@Beta, is that fine?Like PR #371, this change is stacked on top of #369 because of the helpers I introduced there, so I'm marking this as a draft.
Closes #372.