Skip to content

Commit

Permalink
Re-enable version_works_without_rustc on windows.
Browse files Browse the repository at this point in the history
This test was ignored in rust-lang#3189
without much discussion of explaining why.

AFAICT, this test works fine on Windows on both MSVC and GNU.
Empty paths do the expected behavior (preventing cargo from running
rustc). There are some special rules on Windows about discovering the
process to run (such as searching the app's launch directory), but
I do not think that is relevant here. Confirmed by trying to run
`cargo check` in this test fails to find `rustc`.
  • Loading branch information
ehuss authored and Hezuikn committed Sep 22, 2022
1 parent 9b34879 commit 8bf0eb2
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tests/testsuite/version.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ fn simple() {
}

#[cargo_test]
#[cfg_attr(target_os = "windows", ignore)]
fn version_works_without_rustc() {
let p = project().build();
p.cargo("version").env("PATH", "").run();
Expand Down

0 comments on commit 8bf0eb2

Please sign in to comment.