Make it possible for windows-gnu tests to pass #3189
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ |
|
📌 Commit fe64232 has been approved by |
Make it possible for windows-gnu tests to pass Skip test that uses empty path on Windows, because Windows doesn't do the empty path thing.
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
This test was ignored in rust-lang#3189 without much discussion of explaining why. AFAICT, this test works fine on Windows on both MSVC and GNU. Empty paths do the expected behavior (preventing cargo from running rustc). There are some special rules on Windows about discovering the process to run (such as searching the app's launch directory), but I do not think that is relevant here. Confirmed by trying to run `cargo check` in this test fails to find `rustc`.
This test was ignored in rust-lang#3189 without much discussion of explaining why. AFAICT, this test works fine on Windows on both MSVC and GNU. Empty paths do the expected behavior (preventing cargo from running rustc). There are some special rules on Windows about discovering the process to run (such as searching the app's launch directory), but I do not think that is relevant here. Confirmed by trying to run `cargo check` in this test fails to find `rustc`.
This test was ignored in rust-lang#3189 without much discussion of explaining why. AFAICT, this test works fine on Windows on both MSVC and GNU. Empty paths do the expected behavior (preventing cargo from running rustc). There are some special rules on Windows about discovering the process to run (such as searching the app's launch directory), but I do not think that is relevant here. Confirmed by trying to run `cargo check` in this test fails to find `rustc`.
Skip test that uses empty path on Windows, because Windows doesn't do the empty path thing.