-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0: Add RCpair copy! for complex. Rename region
->dims
. Remove deprecation.
#17
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
===========================================
+ Coverage 94.44% 100.00% +5.55%
===========================================
Files 1 1
Lines 36 43 +7
===========================================
+ Hits 34 43 +9
+ Misses 2 0 -2 ☔ View full report in Codecov by Sentry. |
region
->dims
. Remove deprecation.
@timholy my plan, given this is green, is to:
Let me know if you agree. Thanks |
Or maybe it doesn't need to move org? |
Bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweaks, then merge at will.
I agree with the plan. My move of IncrementalSVD revealed that we'll have to change the UUID, as General has a guard against registering a package with the same uuid as in HolyLabRegistry. I will also enhance the README before we release in General, as it seems every so slightly threadbare now 😆 |
region
->dims
. Remove deprecation.region
->dims
. Remove deprecation.
github actions runners seem to be having codecov upload issues but tests pass |
Part of JuliaImages/ImageFiltering.jl#271
copy!
for complex required for irfftregion
arg todims
as per WIP: enable reusing fft plans JuliaImages/ImageFiltering.jl#271 (comment)