Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: RFFT v1.0.0 #105820

Closed

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Apr 29, 2024

@IanButterworth
Copy link
Member

FYI @timholy this is part of the plan discussed here and here

Copy link
Contributor

github-actions bot commented Apr 29, 2024

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Name does not meet all of the following: starts with an upper-case letter, ASCII alphanumerics only, not all letters are upper-case.
  • Name is not at least 5 characters long
  • Package name similar to 10 existing packages.
    1. Similar to NFFT. Damerau-Levenshtein distance 1 is at or below cutoff of 2. Damerau-Levenshtein distance 1 between lowercased names is at or below cutoff of 1. Normalized visual distance 1.30 is at or below cutoff of 2.50.
    2. Similar to STFT. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    3. Similar to GFF3. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    4. Similar to EFIT. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    5. Similar to RAFF. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    6. Similar to NFFT3. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    7. Similar to FFTA. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    8. Similar to FFTW. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    9. Similar to CLFFT. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    10. Similar to BERT. Normalized visual distance 2.48 is at or below cutoff of 2.50.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the Julia Slack to ask for help. Include a link to this pull request.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@IanButterworth
Copy link
Member

I think it would be reasonable to rename to something like ReusableFFTs.jl, if others agree

UUID: 3645faec-0534-4e91-afef-021db0981eec
Repo: https://github.com/JuliaMath/RFFT.jl.git
Tree: 45f2756640780c259d2aaeb3cb742a53aaf38396

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-rfft-3645faec-v1.0.0-85e9d08f43 branch from df2e884 to 61cf52b Compare April 29, 2024 16:37
JuliaRegistrator referenced this pull request in JuliaMath/RealFFTs.jl Apr 29, 2024
@timholy
Copy link
Member

timholy commented Apr 30, 2024

Superseded by #105861

@timholy timholy closed this Apr 30, 2024
@timholy timholy deleted the registrator-rfft-3645faec-v1.0.0-85e9d08f43 branch April 30, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants