Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keg.for: handle non-existent path. #9031

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Keg.for: handle non-existent path. #9031

merged 1 commit into from
Nov 2, 2020

Conversation

MikeMcQuaid
Copy link
Member

Otherwise path.realpath will raise Errno::ENOENT rather than the expected NotAKegError.

Fixes #9015

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Otherwise `path.realpath` will raise `Errno::ENOENT` rather than the
expected `NotAKegError`.

Fixes #9015
@MikeMcQuaid MikeMcQuaid merged commit 5648ae1 into Homebrew:master Nov 2, 2020
@MikeMcQuaid MikeMcQuaid deleted the keg-for-realpath branch November 2, 2020 14:09
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit complains about linking to system frameworks that don't exist
2 participants