salt: migrate to python@3.9

[fxcoudert]

Splitting from #62560
Updating cffi

[fxcoudert]

This is weird, maybe we're not building the right version of cffi?

    In file included from c/_cffi_backend.c:7552:
    In file included from c/cffi1_module.c:20:
    c/call_python.c:26:30: error: incomplete definition of type 'struct _is'
        builtins = tstate->interp->builtins;
                   ~~~~~~~~~~~~~~^

[fxcoudert]

Even if we provide a newer cffi in the resources, it downloads and uses cffi 1.12.2
It actually downloads a lot of other packages, it seems…

[bayandin]

It actually downloads a lot of other packages, it seems…

It is. Salt installs of its dependencies + we use resources for installing additional ones (the switch was done in #52835)

If we want to install a custom version of cffi, we need to use inreplace it in https://github.com/saltstack/salt/blob/v3001.1/pkg/osx/req.txt#L4 (and it looks like we'll need to rework it for the next version of salt because of saltstack/salt#56904)

[fxcoudert]

Upstream report: saltstack/salt#58809

[fxcoudert]

Closing, will reopen once upstream has fixed this.

[fxcoudert]

Weird:

==> brew audit salt --online --git --skip-style
==> FAILED
Error: 1 problem in 1 formula detected
Missing libraries:
  unexpected (/System/Library/Frameworks/AuthenticationServices.framework/Versions/A/AuthenticationServices)
  unexpected (/System/Library/Frameworks/OSLog.framework/Versions/A/OSLog)
  unexpected (/System/Library/Frameworks/PushKit.framework/Versions/A/PushKit)
  unexpected (/System/Library/Frameworks/Speech.framework/Versions/A/Speech)
  unexpected (/System/Library/Frameworks/SystemExtensions.framework/Versions/A/SystemExtensions)
Unexpected missing library linkage detected
salt:
  * salt has broken dynamic library links:

[fxcoudert]

I think those might be a brew bug: Homebrew/brew#9015

[MikeMcQuaid]

Given the failure is only on 10.14 and 10.13: have you checked those files actually exist in the macOS workers on those versions?

[MikeMcQuaid]

Yes, looking at the code: I'm almost certain these frameworks don't exist on these macOS versions.

I've opened Homebrew/brew#9031 which should fix this failure when it's merged and CI is rerun. It may be that brew test fails after that point, though, in which case the error message should be adjusted in brew linkage --test and the PR perhaps reverted.

[MikeMcQuaid]

Rerunning CI now Homebrew/brew#9031 is merged.

[MikeMcQuaid]

Looks good now. Seems those broken system framework referenced didn't matter 🤷🏻.

@fxcoudert should be ✅ to merge.

[BrewTestBot]

🤖 A scheduled task has triggered a merge.