Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends_on :java #16383

Closed
vitorgalvao opened this issue Jan 5, 2016 · 9 comments
Closed

depends_on :java #16383

vitorgalvao opened this issue Jan 5, 2016 · 9 comments
Labels
core Issue with Homebrew itself rather than with a specific cask. enhancement help wanted outdated ready to implement

Comments

@vitorgalvao
Copy link
Member

vitorgalvao commented Jan 5, 2016

Builds on #7993.

Interface for depends_on :java:

  • Similar to depends_on :macos and depends_on :x11. Valid examples:
    • depends_on java: true # any java version
    • depends_on java: '8' # exact version
    • depends_on java: ['6', '7'] # any of array of versions
    • depends_on java: '>= 6' # equal to or greater than version
@vitorgalvao vitorgalvao added enhancement discussion awaiting maintainer feedback Issue needs response from a maintainer. core Issue with Homebrew itself rather than with a specific cask. labels Jan 5, 2016
@adidalal adidalal added ready to implement discussion awaiting maintainer feedback Issue needs response from a maintainer. and removed awaiting maintainer feedback Issue needs response from a maintainer. discussion ready to implement labels Jan 8, 2016
@adidalal
Copy link
Contributor

adidalal commented Jan 8, 2016

Early implementation followup at #16591

@vitorgalvao vitorgalvao changed the title depends_on :java (early and late implementations) depends_on :java Jan 8, 2016
@vitorgalvao vitorgalvao added ready to implement and removed awaiting maintainer feedback Issue needs response from a maintainer. discussion labels Jan 12, 2016
@stale stale bot added the stale Issue which has not received any feedback for some time. label Feb 7, 2019
@vitorgalvao vitorgalvao removed the stale Issue which has not received any feedback for some time. label Feb 8, 2019
@stale stale bot added the stale Issue which has not received any feedback for some time. label Mar 1, 2019
@vitorgalvao vitorgalvao added help wanted and removed stale Issue which has not received any feedback for some time. labels Mar 1, 2019
@Homebrew Homebrew deleted a comment from stale bot Mar 1, 2019
@Homebrew Homebrew deleted a comment from stale bot Mar 1, 2019
@amyspark amyspark pinned this issue Apr 18, 2019
@Homebrew Homebrew deleted a comment Nov 10, 2020
@Homebrew Homebrew deleted a comment Nov 10, 2020
@vitorgalvao
Copy link
Member Author

@reitermarkus What about we scrap this, remove the depends_on_java caveat and start making those casks depends_on formula: 'openjdk'? Do you foresee major problems with that approach? Alternatively, seeing as we’re so integrated with HB, would it be viable to use whatever formulae use to check for java?

@reitermarkus
Copy link
Member

depends_on formula: 'openjdk' does not install it globally, i.e. link it to /Library/Java/JavaVirtualMachines which most GUI apps probably depend on.

@CAMOBAP
Copy link

CAMOBAP commented Mar 30, 2021

Is there a way to achieve depends_on java: '>= 6' behavior? Or the implementation still on the way?

@vitorgalvao
Copy link
Member Author

Is there a way to achieve depends_on java: '>= 6' behavior?

No.

Or the implementation still on the way?

Also no. The feature is desirable, but no one is working on it. This has never evolved in six years. Either we get an outside contribution for it, or we abandon it.

@reitermarkus
Copy link
Member

There is now an openjdk formula and depends_on :java in formulae is deprecated if not already removed.

@CAMOBAP
Copy link

CAMOBAP commented Mar 31, 2021

@vitorgalvao @reitermarkus what if I will add depends_on openjdk@8, does it mean that my formula depends exactly on java 8, and will download java 8 even if java 11 available?

@reitermarkus
Copy link
Member

Yes. You should always depend on the latest version unless an older version is actually necessary.

joewiz added a commit to joewiz/homebrew-cask that referenced this issue Apr 28, 2021
A bug in Java 12-15 could lead to data corruption in eXist; Java 16 compatibility has not yet been confirmed.

I followed the usage of the depends_on_java caveat as described by @reitermarkus in Homebrew#16383 (comment) and Homebrew#16383 (comment)
miccal pushed a commit that referenced this issue Apr 29, 2021
A bug in Java 12-15 could lead to data corruption in eXist; Java 16 compatibility has not yet been confirmed.

I followed the usage of the depends_on_java caveat as described by @reitermarkus in #16383 (comment) and #16383 (comment)
@MikeMcQuaid
Copy link
Member

Closing this, as-of Homebrew/brew#11290 being merged I think we're as good as we're going to get here and it's been open without progress for a long time.

@MikeMcQuaid MikeMcQuaid closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
@Bo98 Bo98 unpinned this issue Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core Issue with Homebrew itself rather than with a specific cask. enhancement help wanted outdated ready to implement
Projects
None yet
Development

No branches or pull requests

6 participants
@MikeMcQuaid @reitermarkus @vitorgalvao @CAMOBAP @adidalal and others