Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 9 Casks: depends_on #40654

Closed
wants to merge 1 commit into from
Closed

Update 9 Casks: depends_on #40654

wants to merge 1 commit into from

Conversation

commitay
Copy link
Contributor

@vitorgalvao Not sure if the depends_on is meant to reoccur, it doesn't seem to make a difference?

@commitay commitay added the awaiting maintainer feedback Issue needs response from a maintainer. label Nov 13, 2017
@commitay commitay changed the title Update 11 Casks: depends_on Update 9 Casks: depends_on Nov 13, 2017
@vitorgalvao
Copy link
Member

I think we decided on multiple depends_on as a stylistic choice. It’s not documented, though, so either way is fine with me, as long as we’re consistent.

@commitay
Copy link
Contributor Author

Just found the relevant discussion #8784

The single value for each depends_on make sense for future implementation of #16383 and #26345

@commitay commitay closed this Nov 13, 2017
@commitay commitay removed the awaiting maintainer feedback Issue needs response from a maintainer. label Nov 13, 2017
@commitay commitay deleted the depends_on branch November 13, 2017 13:50
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@commitay @vitorgalvao