Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of all per-Cask todo comments #8202

Closed
9 of 20 tasks
iggyvolz opened this issue Dec 17, 2014 · 17 comments
Closed
9 of 20 tasks

List of all per-Cask todo comments #8202

iggyvolz opened this issue Dec 17, 2014 · 17 comments

Comments

@iggyvolz
Copy link
Contributor

Below is a list of all todos inside of Homebrew Cask, sorted by todo name and file. For those curious, here's how I generated it: https://gist.github.com/iggyvolz/93f17a54ad2e22077fc0

"Improve this machine-generated value" has thousands of uses so it is simply the number that is listed.
bittorrent-sync.rb

@Amorymeltzer
Copy link
Contributor

I can tell you right off the bat that that last one does seem to be a mistake. Downloading it direct from http://manytricks.com/download/timesink is proper lowercase

iggyvolz added a commit to iggyvolz/homebrew-cask that referenced this issue Dec 17, 2014
@iggyvolz
Copy link
Contributor Author

@Amorymeltzer See #8204.

@iggyvolz
Copy link
Contributor Author

@Amorymeltzer Totally misread that post - scratch that issue above.

iggyvolz added a commit to iggyvolz/homebrew-cask that referenced this issue Dec 17, 2014
@iggyvolz
Copy link
Contributor Author

@Amorymeltzer #8205 should be correct now. Don't know what I was thinking!

@vitorgalvao
Copy link
Member

Thank you for this, @iggyvolz. Titles are a bit overwhelming, though, and make it a bit hard to actually skim the issues. Could you please inline the todo message with the checkbox and the cask/line number, or do something else to make it easier to see?

@iggyvolz
Copy link
Contributor Author

When I initially started writing the code, I did it on the assumption that there were going to be tons of duplicate messages and I did that to save space. Done.

@Amorymeltzer
Copy link
Contributor

Just to continue cleaning the list, improve this machine-generated value was recently added (see #7933 and #7972) to all casks with license :unknown; every single instance of that todo is in that context. Not that those aren't important (I clearly think so) but for the sake of readability they could easily be consolidated into one line (or removed since that's a lot of work for this sort of scope).

@vitorgalvao
Copy link
Member

@Amorymeltzer is correct. The improve this machine-generated value todo should be removed, as it has a different context than the others.

@iggyvolz
Copy link
Contributor Author

Done!

@Amorymeltzer
Copy link
Contributor

Re: the globbing issues, there's discussion in #4759 that was trying to fix the programmer-dvorak issue, and appears to include code that would be informative for fixing the others (contrary to the docs?)

@iggyvolz
Copy link
Contributor Author

Regarding jabber-video.rb, the appropriate commit is 36ee5bb.

"Remove ForcedConfig.plist after install - Required to set the server config manually."

iggyvolz referenced this issue Dec 17, 2014
Required to set the server config manually.
iggyvolz referenced this issue Dec 17, 2014
Home page for this cask points to ASIX's "USB Bridge" page
because this driver covers two of their chipsets.
@rolandwalker rolandwalker changed the title [List] List of all todo's List of all per-Cask todo comments Dec 18, 2014
@rolandwalker
Copy link
Contributor

@iggyvolz thanks! I linkified the Casks for you, edited the subject line, and tagged this as a roadmap.

But I'd advise you to steer discussions away from this tracking bug. GitHub has no threading, there multiple subjects at hand, and people just don't tend to read all the way down a long issue.

@claui
Copy link
Contributor

claui commented Dec 18, 2014

@iggyvolz Nice and useful roadmap! I just added one more item to the list:

"This is a horrible hack […]. The backend code should be fixed" in git-annex.rb

@podlech
Copy link
Contributor

podlech commented Feb 11, 2015

@iggyvolz , regarding Jabber Video, I've added the rm command in order cleanup the configuration. The reason behind this is that this version of Jabber is locked to http://collaboration.iu.edu students and this is the only way we can unlock it. I'm open to suggestions. Sorry for delay on my response.

@adidalal
Copy link
Contributor

adidalal commented Aug 8, 2015

Re: ngrok - ngrok now creates a ~/.ngrok2 directory with an ngrok.yml inside. This is strictly a configuration file (examples here), and should be removed with a zap, but not necessarily an uninstall.

I can put in a pull request to update the formula if deemed appropriate.

@vitorgalvao
Copy link
Member

Please do, @adidalal.

@vitorgalvao
Copy link
Member

This was a great effort, but now most of these are the same (glob related), and some have been fixed and others added without touching the list, so closing as we have open issues for the big pictures.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants