mark license :unknown with explicit todo comment
#7933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
added
the
core
|
+1. Encouraging contributors to add a license value is very desirable. |
rolandwalker
added a commit
that referenced
this pull request
Dec 10, 2014
mark `license :unknown` with explicit todo comment
20 tasks
miccal
removed
the
core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a conversation elsewhere,
license :unknownwas misinterpreted as meaning we don't care about licenses.In fact the
licensestanza is just very new. We have already annotated 36% of Casks in this repo with something more specific than:unknown. I still feel strongly that we should continue accepting submissions that uselicense :unknown, but we should also keep moving forward toward filling in this information.This comment seems like a reasonable step. If accepted, I will mark up existing Casks as well.