-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSL: add depends_on
stanza
#4896
DSL: add depends_on
stanza
#4896
Conversation
I'm not sure if it was intended, but it's missing a test for |
I intentionally left out that test, as it represents undesired behavior. My philosophy is that tests represent the spec. In fact, if I knew Ruby testing frameworks better, I would have put in the exact opposite test, marked as "allowed to fail", and used that to track when the existing limitation gets fixed. It's awesome to have your close review on these patches. I used |
@radeksimko I stubbed |
For forward-compatibility, intentionally undocumented. Currently works only as a synonym: `depends_on :formula` substitutes for `depends_on_formula`, which is intended to be removed. However, this PR also provides additional `depends_on` keys for future expansion of functionality: - `:cask` - `:macos` - `:arch` - `:x11` - `:java` The symbol names were chosen to match those used in Homebrew Formulae. References: Homebrew#4688, Homebrew#2001
DSL: add `depends_on` stanza
Forgotten in Homebrew#4688, but should be considered part of Cask DSL 1.0. A `depends_on` stanza is much less useful without the corresponding `conflicts_with`. References: Homebrew#4896
For forward-compatibility, intentionally undocumented. Currently
works only as a synonym:
depends_on :formula
substitutes fordepends_on_formula
, which is intended to be removed.However, this PR also provides additional
depends_on
keys forfuture expansion of functionality:
:cask
:macos
:arch
:x11
:java
The symbol names were chosen to match those used in Homebrew Formulae.
References: #4688, #2001