-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Xamarin Platform v5.0.1 (build 3) #5099
Conversation
Xamarin's new app installer to install Xamarin Studio with Xamarin iOS, XamarinAndroid, and Xamarin Mac.
Based on the url, this should follow a version 'latest'
sha256 :no_check There are scripts and documentation geared for that. Have you read through them yet? |
Done... is adding a new commit okay? I have read through all of it, missed the version stuff, though! The commented out lines are based upon what I read in the documentation. But I get the following error every time I attempt to uninstall it with the uninstall lines uncommented: |
We usually ask for a cask commit to be in a single commit. I just noticed though that there is no |
Okay. I'll try to figure out how to squash the two commits. But the folders that need to be removed upon uninstalling are still there. So right now, running Yeah, the |
Here is a good article on squashing your commits |
@Fapper trying it on my own machine caused a GUI to pop up to continue the installation. Traditionally, we don't accept installers of this king, @caskroom/maintainers, should we allow this in? Also, it can't be called directly via |
Interesting... I stole most of the code from the |
@Fapper I know, I experimented with getting it to work directly via MacTex also installs via a |
The issue you’re experiencing with uninstalling is known, and should be fixed in the future. It occurs when a cask has an If it’s calling a GUI, then no, we shouldn’t (last paragraph). At least not until (if) we change that policy, though. The The cask is also missing a On a final note, how will this interact with |
@nanoxd I think @vitorgalvao Gotcha, will add those workarounds for now. The policy of no GUI installers definitely makes sense, but I spent some time trying other solutions... it seems as if Xamarin really don't want you to just exclusively install Xamarin Studio, forcing all users to use this installer if they want to use Xamarin Studio. You're right about fact that the application names would be exatly the same. Hadn't thought of that. I'm not sure how to tackle this situation. Should I inject some ruby code that runs |
Forgot to mention that in these cases, you should use Setting up such a conditional strikes me as something that could easily break, even by changing something about homebrew-cask’s internals — it shouldn’t be too dependent on that. It seems like what XamarinPlatform does is simply facilitate the install of some SDKs, while installing XamarinStudio (the same from the other cask) at the same time. Can you confirm that to be the case? If it is, we could possibly not have to worry much about that. |
Looking at and playing with I originally created the XamarinPlatform cask because XamarinStudio is stuck at version 4.2.4, and seemingly will never be able to be updated past that because Xamarin have started to use this new installer that my cask uses, installing Xamarin Studio version 5 and above (I assume). |
That seems to be the case. Going to the website, they say “Xamarin Studio comes with Xamarin”, and if you try to download it, you’ll get this same download. This means we can scrape the XamarinStudio cask from this repo, and move it to caskroom versions. This cask you’re submitting should also be renamed to |
I believe the Casks Sounds good. Would it be easiest if I submitted a new pull request with the I can also look into adding these three to caskroom-versions. |
Agreed.
Whatever works best for you. I’ll leave that to what you find easier/faster for you.
That would be appreciated. You can do it all in a single pull request. Let me know if you have any trouble with any of the steps. And thank you for the contribution, and working so fast with us on it. |
Will attempt to do it all in one pull request in a little bit. Still very new to contributing to GitHub repos, so we'll see how it goes. 😄 Thanks a ton for your help, too! |
@Fapper thanks for bringing the knowledge on Xamarin. @vitorgalvao is right, you need to add caskroom_only true to convince |
Xamarin's new app installer to install version 5 (and above) of Xamarin Studio with Xamarin iOS,
Xamarin Android, and Xamarin Mac. This is meant as a replacement for the current Xamarin casks:
xamarin-android
,xamarin-ios
, andxamarin-studio
, locked at version 4.I need help with the uninstall logic. I need to remove folders
/Applications/Xamarin Studio.app
and~/Library/Developer/Xamarin
. It's currently giving an error upon runningbrew cask uninstall xamarin-platform