Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cask Xamarin, replacing older Xamarin Casks #5118

Merged
merged 1 commit into from
Jun 29, 2014
Merged

Add Cask Xamarin, replacing older Xamarin Casks #5118

merged 1 commit into from
Jun 29, 2014

Conversation

martinbjeldbak
Copy link
Contributor

These older scraped Casks are XamarinAndroid, XamarinIos, and XamarinStudio. I have submitted a pull request to have these Casks added to homebrew-versions, as they have been replaced by Xamarin's new installer, included in this commit. See #5099 for comments by collaborators.

See pull request Homebrew/homebrew-cask-versions#307, which adds the scraped versions of XamarinAndroid, XamarinIos, and XamarinStudio to the homebrew-versions Cask repository.

@vitorgalvao
Copy link
Member

Thank you. One small note, though. Instead of calling caveats twice, you should do something like

  caveats do
    puts <<-EOS.undent
      This app requires the JRE (Java Runtime Environment) to be installed
    EOS
    manual_installer 'Install Xamarin.app'
  end

@vitorgalvao vitorgalvao self-assigned this Jun 29, 2014
These packages are: xamarin-android, xamarin-ios, and xamarin-studio.
They have been added to homebrew-versions.

Only call caveats once on Xamarin cask
@martinbjeldbak
Copy link
Contributor Author

Ah, smart... thanks! Your fix has been squashed and added.

@vitorgalvao
Copy link
Member

Thank you. Merging this in.

vitorgalvao added a commit that referenced this pull request Jun 29, 2014
Add Cask Xamarin, replacing older Xamarin Casks
@vitorgalvao vitorgalvao merged commit a4defc9 into Homebrew:master Jun 29, 2014
@martinbjeldbak martinbjeldbak deleted the xamarin branch June 29, 2014 22:07
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants